1156134 - Findbar does not react (again)

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[kevink9876543]

User Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:25.0) Gecko/20100101 Firefox/25.0

Steps to reproduce:

SeaMonkey 2.37 built from c-c rev 6f8790980905 / m-c rev a32e3b93c8d8
new profile

On the page that shows up on startup:
1) search for text on the page that isn't on the page
2) search for text that is on the page, then keep hitting "Find Next" or "Find Previous" buttons until it wraps around


Actual results:

The findbar doesn't react at all.  This error is in error console on browser startup:

Error: TypeError: this._browser.messageManager is undefined
Source File: chrome://global/content/bindings/findbar.xml
Line: 272


(Probably need to port bug 1154799 to SeaMonkey somehow, it seems to fix a very similar sounding issue.)


Expected results:

The findbar should turn red and say "Phrase not found" at step 1.
The findbar should show the "Reached end of page..." message during step 2.

Comment 1

[kevink9876543]

Attachment: Patch that seems to get this back working again

(OK so this patch was created mostly out of wild guessing...)

Comment 2

[Philip Chee]

Comment on attachment 8597442 [details] [diff] [review]
Patch that seems to get this back working again

Bug 1133981 (e10s-ify findbar FAYT key handling) introduced a dependency on a "messageManager" property on browser.xml[1]. Firefox has one findbar per browser while we have one global findbar four our tabbrowser. This patch looks like the right fix but I'm going to punt this to Neil as he's touched the findbar code recently.

[1] http://hg.mozilla.org/mozilla-central/rev/6bd63b661b78#l5.39

Comment 3

[[e-mail]]

Comment on attachment 8597442 [details] [diff] [review]
Patch that seems to get this back working again

Seems reasonable to me, assuming that the feedback+ includes some sort of testing.

Comment 4

[Philip Chee]

Pushed to comm-central a=IanN CLOSED TREE
http://hg.mozilla.org/comm-central/rev/2d6f3a608268