1156145 - [Settings] cleaned up settings related scripts in xfail.list

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

As title, in this phase, it would be nice if we can clean up some old codes in xfail.list.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] EragonJ:bug-1156145 > mozilla-b2g:master

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8594648 [details] [review]
[gaia] EragonJ:bug-1156145 > mozilla-b2g:master

Hi all, this is a simple refactor works trying to remove all settings related files from xfail.list. Please help me review related parts that you guys participate in before ! Thanks !

@Ian, need your help for bluetooth.js
@Arthur, need your help for the other parts in Settings app.

Comment 3

[[e-mail], [e-mail]]

Comment on attachment 8594648 [details] [review]
[gaia] EragonJ:bug-1156145 > mozilla-b2g:master

In part of bluetooth.js, r+ with me. And I leave one comment which is relative with indent on GitHub. Please take a look for readable style. Thanks for EJ's effort here:)

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8594648 [details] [review]
[gaia] EragonJ:bug-1156145 > mozilla-b2g:master

Thanks for the clean up. r=me with the comments addressed.

Comment 6

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#IQjOWOi-TSeLAmyPAuXNSQ

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/dc24751bb9f00046805f4294683b3e6712baed26