1156217 - Adding a .1 when bulk signing all addons might lead to version clashes

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Mathieu Agopian [:magopian]]

Simply adding a .1 when bumping versions after running the "sign_addons" or "process_addons --task sign_addons" management commands could lead to version clashes.

Simple use case: an addon with already a version 1 and 1.1. It would result in two versions 1.1 and 1.1.1 after the bumps, but we only want to bump if we signed, and we only want to sign if the version/files are already reviewed (prelim or full).

If the initial version 1.1 isn't reviewed yet, it shouldn't be signed, and thus shouldn't be bumped, and it would then result in two versions 1.1 (the initial version 1 being bumped to 1.1, and the initial version 1.1 not being bumped).

Instead of simply adding a ".1" to the version number, we should use something like ".1-signed", which is far less likely to lead to clashes.

Comment 1

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/517

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

I agree this is better than a version collision. However, I think that ".1-signed" is a higher version number than ".1", meaning that in this case the bumped version would still be the latest version of the add-on even after the ".1" passes review.

We should probably find a way to warn either devs or whoever is running the bump script about these cases, so we can handle them individually. Hopefully (and probably) there won't be many.

Comment 3

[Mathieu Agopian [:magopian]]

We double checked with :kmag, and we should be fine with that use case anyway. We sign versions "in place" (we don't create new ones), and versions are either sorted by id or by creation date.

Comment 4

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/1a19b11958a2bdf9083c51f55deb67ecb714c746