Console should use the new API for tracking promises that are rejected and not handled

NEW
Unassigned

Status

()

Firefox
Developer Tools: Console
P2
normal
3 years ago
2 years ago

People

(Reporter: fitzgen, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [polish-backlog][difficulty=medium])

New API implemented in bug 1083361.

Note that this API is not GC-sensitive (a very good thing), but requires a little more finesse on the devtools side. It is essentially an event stream of "this promise was rejected and unhandled" and "nevermind, it got handled later" events.

This means we will need a way of either hiding, striking out, or graying out old console messages.
Blocks: 885333
Jeff - I took a stab at prioritizing. What do you think?
Flags: needinfo?(jeff)
OS: Mac OS X → All
Priority: -- → P2
Hardware: x86 → Unspecified
Whiteboard: [devedition-40][difficulty=medium]
(In reply to Joe Walker [:jwalker] (overloaded - needinfo me or ping on irc) from comment #1)
> Jeff - I took a stab at prioritizing. What do you think?

Sounds good. WHy is this a devedition-40 bug? It seems to me there won't be any user impact for this ( unless I'm reading it wrong ) without additional console frontend work.

FYI - when referencing me in bugzilla always type ':canuckistani' with the ':' otherwise you'll find an older personal account and I won't see this right away, it gets buried in Inbox.
Flags: needinfo?(jeff)
User impact is more reliable promise rejection reporting. Don't have to wait for a GC anymore (sometimes many seconds) -- get feedback immediately.
Blocks: 1155059
(In reply to Nick Fitzgerald [:fitzgen] from comment #3)
> User impact is more reliable promise rejection reporting. Don't have to wait
> for a GC anymore (sometimes many seconds) -- get feedback immediately.

Got it - thanks.
Whiteboard: [devedition-40][difficulty=medium] → [polish-backlog][difficulty=medium]
Also, note that, in my quest to ensure that javascript stacks are always displayed in the console,
I found that Promise unhandled reports are still missing stacks.
That's because the old reprecated way to report it from C++ here:
  http://mxr.mozilla.org/mozilla-central/source/dom/promise/Promise.cpp#1187
uses AsyncErrorReporter, which doesn't support passing stack.
So, ideally, we would do this bug and also address the stack being missing!
You need to log in before you can comment on or make changes to this bug.