1156856 - Move to CodeMirror

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P3)

Description

[Kadir Topal [:atopal]]

We are currently using ACE as our editor, due to bugs like bug 821982 that affect RTL languages we would like to move to an editor that has better support for a wide variety of locales, and especially bidi support.

It seems like CodeMirror would be that alternative. This bug is either going to be the implementation bug or the meta bug depending on how involved the move would be

Comment 1

[Mohammed Yaseen Khan [:foxt7ot]]

(In reply to Kadir Topal [:atopal] from comment #0)
> We are currently using ACE as our editor, due to bugs like bug 821982 that
> affect RTL languages we would like to move to an editor that has better
> support for a wide variety of locales, and especially bidi support.
> 
> It seems like CodeMirror would be that alternative. This bug is either going
> to be the implementation bug or the meta bug depending on how involved the
> move would be

Thanks for listening to my suggestion as I it came to my knowledge that Khan Academy(https://github.com/ajaxorg/ace/issues/1429) is facing similar issue with Ace as we are facing. AFAIK most probably we will not going to face this issue in Code Mirror.

Comment 2

[Michael Cooper [:mythmon]]

Here is a demo of CodeMirror's bidirectional (bidi) text support, in a mixed-direction environment. At a glance, it seems right to me, but I'm not very familiar with any RTL languages. http://codemirror.net/demo/bidi.html It would be great if someone who types/reads a RTL language could play with that demo and see if it acts as expected.

Comment 3

[Safwan Rahman (:safwan)]

Mythmon, I can read Arabic and it seems that Codemirror is working fine with Arabic,(RTL Language)
I have tried with Editing in Codemirror for Arabic, and its working pretty well
Also, I have tried with complex character like Bengali, and it seems Codemirror also handle it perfectly.

Comment 4

[Mohammed Yaseen Khan [:foxt7ot]]

(In reply to Mike Cooper [:mythmon] from comment #2)
> Here is a demo of CodeMirror's bidirectional (bidi) text support, in a
> mixed-direction environment. At a glance, it seems right to me, but I'm not
> very familiar with any RTL languages. http://codemirror.net/demo/bidi.html
> It would be great if someone who types/reads a RTL language could play with
> that demo and see if it acts as expected.

So, I tried the demo. It is working fantastic comparatively to Ace , Though few things should be mind in code mirror also. The cursor position is static that is, it remains at left most position while typing.

Comment 5

[Michael Cooper [:mythmon]]

Switching to code mirror will be pretty straight forward, but porting the SUMO mode that Tobbi wrote will be non-trivial, so this is 3pts. Additionally, 2015.8 is full, so I'm taking this out of the sprints for now.

Comment 6

[Rehan Dalal (Inactive)]

Landed:
https://github.com/mozilla/kitsune/commit/54988ecee45c2bea943255e92ff1dea77654ea77

Pushed to prod by me, right now.

Comment 7

[Mohammed Yaseen Khan [:foxt7ot]]

Attachment: Out of view.PNG

@rehan As you can clearly see from the snap that first one-two letters are out view. I hope this problem is not of codemirror.

Comment 8

[Michael Cooper [:mythmon]]

Mohammed, can you file a separate bug for this issue? Bugzilla works best when we keep individual bugs focused on specific tasks. Thank you!