1156921 - Backout Suggested Tiles (bug 1120311) from 38.0

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: Testing will happen for 38.1, so we need to remove functionality before 38.0 mozilla-release branches from mozilla-beta.

This undoes the uplift from bug 1148859 and bug 1152145 that landed for Suggested Tiles affiliate bug 1120311.

We'll have a separate bug to reland in mozilla-beta for 38.1.


hg diff --reverse -c e66ad17db13f > backouts.patch
hg diff --reverse -c daf8a9291a9b >> backouts.patch
hg diff --reverse -c 98144ed917cb >> backouts.patch
hg diff --reverse -c 96e8fba7c4c4 >> backouts.patch
hg diff --reverse -c 311733df5675 >> backouts.patch
hg diff --reverse -c da2535172770 >> backouts.patch
hg diff --reverse -c 1d9b014f0414 >> backouts.patch
hg diff --reverse -c 5fd426f495ff >> backouts.patch
hg diff --reverse -c 6892b485a7e0 >> backouts.patch
hg diff --reverse -c 4afccec73fb9 >> backouts.patch
hg diff --reverse -c 60f350a6b8b8 >> backouts.patch
hg diff --reverse -c 745269d59b33 >> backouts.patch
hg diff --reverse -c 65f2aa5f2dd7 >> backouts.patch
hg diff --reverse -c 56763fc69140 >> backouts.patch
hg diff --reverse -c db2b58500934 >> backouts.patch
hg diff --reverse -c e9021ea8d7ca >> backouts.patch
hg diff --reverse -c 1a007e477655 >> backouts.patch
hg diff --reverse -c 48564fb0e663 >> backouts.patch
hg diff --reverse -c 869ba4681d1b >> backouts.patch
hg diff --reverse -c 83bcf11d00ef >> backouts.patch
hg import backouts.patch

Comment 1

[Ed Lee :Mardak]

There wasn't a clean way to turn off the new suggested tiles functionality without breaking the existing tiles functionality.

When does this need to land by today?

I've pushed the backout patch to try to make sure everything is okay.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=146d19c36368

Comment 2

[Sylvestre Ledru [:Sylvestre]]

(In reply to Ed Lee :Mardak from comment #1)
> There wasn't a clean way to turn off the new suggested tiles functionality
> without breaking the existing tiles functionality.
It would be nice to fix that for 38.0.5

> When does this need to land by today?
We can wait tomorrow!

Comment 3

[Ed Lee :Mardak]

(In reply to Sylvestre Ledru [:sylvestre] from comment #2)
> (In reply to Ed Lee :Mardak from comment #1)
> > There wasn't a clean way to turn off the new suggested tiles functionality
> > without breaking the existing tiles functionality.
> It would be nice to fix that for 38.0.5
The specific issue is that the new Firefox code removed support for the old API endpoint. The fix would be allow Firefox to work with both the old and new endpoints, but I don't think it's super useful to have a fixed version of Firefox supporting the two different codepaths when it would normally only use the new endpoint.

To be clear, our servers are backwards compatible and will support the old endpoint for existing Firefox users on older versions.

Comment 4

[Ed Lee :Mardak]

sylvestre, should I just do the backout directly on mozilla-release? I was about to push and saw a bunch of commits come in for mozilla-beta.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

(In reply to Ed Lee :Mardak from comment #4)
> sylvestre, should I just do the backout directly on mozilla-release? I was
> about to push and saw a bunch of commits come in for mozilla-beta.
Yes, please. Sorry that the merge arrived at the same time you were working on it...

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-release/rev/d7ca3b75c842

Comment 7

[Ryan VanderMeulen [:RyanVM]]

It's trivial for me to back this out from beta when I do the next release -> beta merge. Let's file a new bug for that (a la bug 1157196), though, so we can better track it.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d7ca3b75c842

And to close the loop, the was backed out from beta in bug 1157309.

Comment 9

[Cornel Ionce [:noni] [Hubs QA]]

The Suggested Tiles was properly backed out.

Tested across platforms (Windows 7 64-bit, Windows 8.1 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit) on Firefox 38 beta 8, build ID: 20150426174329

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Ed, as we are going to postpone this, could you open a new bug to backout also this change from m-b? Thanks

Comment 11

[Ed Lee :Mardak]

Yes, we want this removed from 38.0.5 now and done so in bug 1161245:

https://hg.mozilla.org/releases/mozilla-release/rev/9a494b64194e