1157246 - Firefox for iOS (Build 8-16): authentication and save password dialogs are not fully localized

Status: RESOLVED DUPLICATE of bug 1168537

(Firefox for iOS :: Browser, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: Authentication dialog

Based on the fact that the dialog is partially localized, I assume build 8 picked up my strings (committed in r140377).

But the main string is not localized in-product
http://viewvc.svn.mozilla.org/vc/projects/l10n-misc/trunk/firefox-ios/it/firefox-ios.xliff?revision=140518&view=markup#l82

Comment 1

[Francesco Lodolo [:flod]]

Still there in build 9 on testflight.

Comment 2

[Francesco Lodolo [:flod]]

See also Save password dialog with the same issue
https://bugzilla.mozilla.org/attachment.cgi?id=8595984

Comment 3

[Wesley Johnston (:wesj)]

I'm confused. Those strings are obviously localized in code: https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Browser/PasswordHelper.swift#L230

They aren't being picked up and used? Stefan, do you have any ideas why this would happen?

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I see the strings for this in:

  <file original="Client/Localizable.strings" source-language="en" datatype="plaintext" target-language="en"
    ...
      <trans-unit id="A username and password are being requested by %@. The site says: %@">
        <source>A username and password are being requested by %1$@. The site says: %2$@</source>
        <target>A username and password are being requested by %1$@. The site says: %2$@</target>
        <note>Authentication prompt message with a realm. First parameter is the hostname. Second is the realm string</note>
      </trans-unit>

Maybe they were added after the last time we did a string export?

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Stefan Arentz [:st3fan] from comment #4)
> Maybe they were added after the last time we did a string export?

This started on build 8, I never saw that dialog localized (note that my file is up to date with iOS code, not with the extracted en-US strings).

Issue is somewhere in the code.

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I see the same with my locale set to Dutch. I'll investigate why this is happening.

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The problem is in the XLIFF. I am not sure yet if this is an export problem of Xcode or if this is something our export-post-processing scrripts are doing.

In SVN I see this:

81            <trans-unit id="A username and password are being requested by %@. The site says: %@">
82 	        <source>A username and password are being requested by %1$@. The site says: %2$@</source>
83 	        <target>Sono stati richiesti un nome utente e una password da %1$@. Il sito riporta: %2$@</target>
84 	        <note>Authentication prompt message with a realm. First parameter is the hostname. Second is the realm string</note>
85 	      </trans-unit>

But that should be:

81            <trans-unit id="A username and password are being requested by %@. The site says: %@">
82 	        <source>A username and password are being requested by %@. The site says: %@</source>
83 	        <target>Sono stati richiesti un nome utente e una password da %1$@. Il sito riporta: %2$@</target>
84 	        <note>Authentication prompt message with a realm. First parameter is the hostname. Second is the realm string</note>
85 	      </trans-unit>

The <source> must not have positional string arguments.

Comment 8

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Another option is that the culprit is xliff-to-strings.py, where we write out the name/value pairs as:

  "trans-unit.source" = "trans-unit-destination";

But I think that actually should be:

  "trans-unit[id]" = "trans-unit.destination";

Comment 9

[Francesco Lodolo [:flod]]

As commented on IRC, the problem is not the extraction, since the file comes out that way with xcodebuild -exportLocalizations

One note though: we might actually need to reorder variables, so positional arguments are actually useful in these cases.

Comment 10

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Marking this as a dupe of bug 1168537