1168537 - Export strings files with the trans-unit id as key instead of the source string

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

When exporting strings files (xliff-to-strings.py), use the trans-unit[id] as the string key. Right now we use trans-unit.source but that is not correct.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/501

When exporting strings files `(xliff-to-strings.py)`, use the `trans-unit[id]` as the string key. Right now we use `trans-unit.source` but that is not correct.

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8610760 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/501

This definitely solves the issue on the build side. 

Run script/import-locales.sh, tested with XCode Simulator in Italian and both dialogs from bug 1157246 are fixed.

I kind of remember testing in XCode, importing my localization from XCode (without running scripts) and running the simulator, and that the string was untranslated there too. But I tried again tonight (with quite a lot of build failures, thanks XCode) and that seems to work just fine, so maybe my memory is failing me.

Comment 5

[Francesco Lodolo [:flod]]

I see that the PR is merged, and both dialogs work for me in build 18 (testflight). I guess we can mark this as FIXED:

Comment 6

[Jessica Jiang [:jjiang]]

Attachment: Pull Request

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8898045 [details] [review]
Pull Request

Moved to https://bugzilla.mozilla.org/show_bug.cgi?id=1390953