1157303 - Display and handle notifications for received tabs

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Richard Newman [:rnewman]]

I'm going to land this half-baked: we'll show a notification, but it's not localized, has no icon, and doesn't do anything when tapped.

This bug is to fill in the rest: you get a URL and a title, go do something with it.

Comment 1

[Richard Newman [:rnewman]]

See BrowserProfileSyncDelegate in Profile.swift.

Comment 2

[Emily Toop (:fluffyemily)]

OK, so what _should_ it do when tapped? 
And what should the icon be?
And is there anything else this should do? 
And if you don't know, who's should I ask?

Comment 3

[Richard Newman [:rnewman]]

When the notification is tapped, we should load the provided URL in a new tab in Firefox.

The icon should be a platform-suitable rendition of the Firefox icon. 302 :tecgirl for that, and any questions about the UX.

Any strings should be localized, and ideally we can present both title (if known) and URL, but beyond that, it doesn't need to do anything else at this point.

(Eventually we might want to go straight into our external app handler to avoid flicking through the browser UI to launch a map URL or open a tweet, but we can leave that until our external app stuff is stable.)

Comment 4

[Emily Toop (:fluffyemily)]

Attachment: Pull request

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8623183 [details] [review]
Pull request

Looks good! Just a few small comments in the PR.

Comment 6

[Emily Toop (:fluffyemily)]

Attachment: New Tab Notification

Comment 7

[Emily Toop (:fluffyemily)]

Attachment: New Tab Notification Actions

Comment 8

[Emily Toop (:fluffyemily)]

Attachment: New Tab Notification Lock Screen

Comment 9

[Emily Toop (:fluffyemily)]

Attachment: New Tab Notification Lock Screen Actions