1157317 - Fake apps should have unique names

Status: RESOLVED WORKSFORME

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[krupa raj[:krupa]]

To help with tests and to avoid general confusion, please generate fake apps with unique names.

Comment 1

[Bob Silverberg [:bsilverberg]]

There is also an issue currently on dev with the display name of the app not matching the name in the manifest.

Comment 2

[Allen Short [:ashort]]

https://github.com/mozilla/zamboni/commit/a3b28d1189c1238ddd09254bf1be89888aaa16ee

Comment 3

[Valentina Virlics [:vvalentina], VPN QA]

The fake apps don't have unique names... or it will only have unique names after you re-generate fake test apps?
Please see the screenshot: http://screencast.com/t/fJYoQMVl

Comment 4

[Allen Short [:ashort]]

This should have gone out with the last db refresh, looks like slugs are unique but display names still aren't.

Comment 5

[Bob Silverberg [:bsilverberg]]

I wanted to point out that there is another issue mentioned in comment 1, which is that the app name in the manifest doesn't match the app name as displayed. Should I open a separate bug for that?

Comment 6

[Allen Short [:ashort]]

both issues fixed with today's db refresh.

Comment 7

[Valentina Virlics [:vvalentina], VPN QA]

Verified as fixed on MP-dev FF41(Win 7).
Postfix screenshot:http://screencast.com/t/nM4SuzTIijZZ
Closing bug.

Comment 8

[krupa raj[:krupa]]

This is back. The app in question is called “Food Truck Salad 10” in marketplace, but is installed with the name “en-US”

reopening so that ashort can take a look.

Comment 9

[Allen Short [:ashort]]

packaged apps with localized names were generated incorrectly.

https://github.com/mozilla/zamboni/commit/eb078808fc28cab53cc5cb4ad2f97b56d98a881b

Comment 10

[krupa raj[:krupa]]

This is not fixed.

1. Search for Swanky Pie 1
2. Install the first app listed among the search results
3. Notice the toast upon successful install

expected behavior:
Toast says "Swanky Pie 1 installed"


actual behavior:
Toast says "Swanky Pizza installed"

Comment 11

[Bob Silverberg [:bsilverberg]]

Note also that the old behaviour, as described in https://bugzilla.mozilla.org/show_bug.cgi?id=1157317#c8  seems to be back. I.e., installing the app called "Food Truck Salad 10" results in a message saying "en-US installed".

Comment 12

[Dave Hunt [:davehunt] [he/him] ⌚BST]

The affected automated test has been passing consistently since at least 11-Jul-2015. I'm unable to replicate the behaviour from comment 8 because I don't get any results for "Food Truck Salad 1". I am able to replicate the behaviour from comment 10 though, but I'm going to raise this as a separate issue - it doesn't seem entirely relevant to this bug report.