1157396 - [FXA] The 'Back' and 'Next' buttons are not properly spaced (too close, touching) when creating a FX account

Status: VERIFIED FIXED

(Firefox OS Graveyard :: FxA, defect)

Description

[Joshua Mitchell (Inactive)]

Attachment: NoTouching!.png

Description:
buttons are touching, not spaced properly. This look is inconsistent with other 2 button option looks.


Repro Steps:
1) Update a Flame to 20150422010202
2) Launch Settings
3) Create FX Account

Actual:
Next and Last buttons not properly spaced

Expected:
Proper spacing consistent with other 2 button looks

Environmental Variables:
Device: Flame 3.0 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150422010202
Gaia: 15134b080b5f406e5aa36f5136c17dafb4e31f64
Gecko: 946ac85af8f4
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0


Repro frequency: 7/7
See attached: screenshot

Comment 1

[Joshua Mitchell (Inactive)]

This issue does NOT reproduce in 2.2

Actual results: Buttons are properly spaced

Comment 2

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Visible regression, looks like the back button got shifted to the right.

Requesting a window.

Comment 3

[Yeojin Chung [:YeojinC]]

b2g-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame 3.0
BuildID: 20150405105806
Gaia: ef61ebbe5de8c2c9fc2a8f74a12455044c3b82e9
Gecko: b4544b0ddd2a
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

First Broken Environmental Variables:
Device: Flame 3.0
BuildID: 20150405130859
Gaia: 5f85b2592fb75aebc3d3fefeec38000143919bb2
Gecko: 57005eed4733
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce 
Gaia: ef61ebbe5de8c2c9fc2a8f74a12455044c3b82e9
Gecko: 57005eed4733

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 5f85b2592fb75aebc3d3fefeec38000143919bb2
Gecko: b4544b0ddd2a

https://github.com/mozilla-b2g/gaia/compare/ef61ebbe5de8c2c9fc2a8f74a12455044c3b82e9...5f85b2592fb75aebc3d3fefeec38000143919bb2

Caused by bug 1118437

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Ahmed, can you take a look at this please? This might have been caused by the landing for bug 1118437.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: regression from bug 1118437. Fernando, could you take a look? Thanks.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1157396.fxabuttons > mozilla-b2g:master

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8653383 [details] [review]
[gaia] ferjm:bug1157396.fxabuttons > mozilla-b2g:master

It is preferable if we could switch to components but I don't know what it takes to make that reach here.

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Thank you Tim. We are getting rid of this flow at bug 1198639, so I don't think it's worth any frontend refactor.

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/d784c81961d82cbe9e111405468c590a8345856c

Comment 10

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: Next and Back buttons are properly spaced.
See attachment: verified_FlameKK_v2.5.png
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150905150219
Gaia Revision          03be7d8918bed58c92a40bba211bbbc97a0e516a
Gaia Date              2015-09-04 11:56:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/139446daedab3d00b9f0faba25e1e82191c8c8d1
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150905.183746
Firmware Date          Sat Sep  5 18:38:03 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20150905112803
Gaia Revision          03be7d8918bed58c92a40bba211bbbc97a0e516a
Gaia Date              2015-09-04 11:56:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/139446daedab3d00b9f0faba25e1e82191c8c8d1
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150905.105729
Firmware Date          Sat Sep  5 10:57:37 UTC 2015
Bootloader             s1

Comment 11

[Shally Li（leave from Mozilla）]

Attachment: verifed_FlameKK_v2.5.png