[FXA] The 'Back' and 'Next' buttons are not properly spaced (too close, touching) when creating a FX account

VERIFIED FIXED

Status

Firefox OS
FxA
VERIFIED FIXED
3 years ago
2 years ago

People

(Reporter: Joshua Mitchell (Inactive), Assigned: ferjm)

Tracking

({regression})

unspecified
ARM
Gonk (Firefox OS)
regression

Firefox Tracking Flags

(blocking-b2g:2.5+, b2g-v2.2 unaffected, b2g-master verified)

Details

(Whiteboard: [3.0-Daily-Testing])

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
Created attachment 8596115 [details]
NoTouching!.png

Description:
buttons are touching, not spaced properly. This look is inconsistent with other 2 button option looks.


Repro Steps:
1) Update a Flame to 20150422010202
2) Launch Settings
3) Create FX Account

Actual:
Next and Last buttons not properly spaced

Expected:
Proper spacing consistent with other 2 button looks

Environmental Variables:
Device: Flame 3.0 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150422010202
Gaia: 15134b080b5f406e5aa36f5136c17dafb4e31f64
Gecko: 946ac85af8f4
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0


Repro frequency: 7/7
See attached: screenshot
(Reporter)

Comment 1

3 years ago
This issue does NOT reproduce in 2.2

Actual results: Buttons are properly spaced
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
[Blocking Requested - why for this release]:
Visible regression, looks like the back button got shifted to the right.

Requesting a window.
blocking-b2g: --- → 3.0?
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
Keywords: regressionwindow-wanted
QA Contact: ychung
b2g-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame 3.0
BuildID: 20150405105806
Gaia: ef61ebbe5de8c2c9fc2a8f74a12455044c3b82e9
Gecko: b4544b0ddd2a
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

First Broken Environmental Variables:
Device: Flame 3.0
BuildID: 20150405130859
Gaia: 5f85b2592fb75aebc3d3fefeec38000143919bb2
Gecko: 57005eed4733
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce 
Gaia: ef61ebbe5de8c2c9fc2a8f74a12455044c3b82e9
Gecko: 57005eed4733

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 5f85b2592fb75aebc3d3fefeec38000143919bb2
Gecko: b4544b0ddd2a

https://github.com/mozilla-b2g/gaia/compare/ef61ebbe5de8c2c9fc2a8f74a12455044c3b82e9...5f85b2592fb75aebc3d3fefeec38000143919bb2

Caused by bug 1118437
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Keywords: regressionwindow-wanted
QA Contact: ychung
Ahmed, can you take a look at this please? This might have been caused by the landing for bug 1118437.
Blocks: 1118437
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker) → needinfo?(nefzaoui)
Triage: regression from bug 1118437. Fernando, could you take a look? Thanks.
blocking-b2g: 2.5? → 2.5+
Flags: needinfo?(ferjmoreno)
Created attachment 8653383 [details] [review]
[gaia] ferjm:bug1157396.fxabuttons > mozilla-b2g:master
(Assignee)

Updated

2 years ago
Assignee: nobody → ferjmoreno
Flags: needinfo?(ferjmoreno)
(Assignee)

Updated

2 years ago
Attachment #8653383 - Flags: review?(timdream)
Comment on attachment 8653383 [details] [review]
[gaia] ferjm:bug1157396.fxabuttons > mozilla-b2g:master

It is preferable if we could switch to components but I don't know what it takes to make that reach here.
Attachment #8653383 - Flags: review?(timdream) → review+
(Assignee)

Comment 8

2 years ago
Thank you Tim. We are getting rid of this flow at bug 1198639, so I don't think it's worth any frontend refactor.
(Assignee)

Comment 9

2 years ago
https://github.com/mozilla-b2g/gaia/commit/d784c81961d82cbe9e111405468c590a8345856c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: Next and Back buttons are properly spaced.
See attachment: verified_FlameKK_v2.5.png
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150905150219
Gaia Revision          03be7d8918bed58c92a40bba211bbbc97a0e516a
Gaia Date              2015-09-04 11:56:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/139446daedab3d00b9f0faba25e1e82191c8c8d1
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150905.183746
Firmware Date          Sat Sep  5 18:38:03 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20150905112803
Gaia Revision          03be7d8918bed58c92a40bba211bbbc97a0e516a
Gaia Date              2015-09-04 11:56:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/139446daedab3d00b9f0faba25e1e82191c8c8d1
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150905.105729
Firmware Date          Sat Sep  5 10:57:37 UTC 2015
Bootloader             s1
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][MGSEI-Triage+]
status-b2g-master: affected → verified
Created attachment 8657516 [details]
verifed_FlameKK_v2.5.png
Flags: needinfo?(nefzaoui)
You need to log in before you can comment on or make changes to this bug.