115748 - NS_THEME_PROGRESSBAR* implementations (Windows)

Status: RESOLVED FIXED

(Core Graveyard :: Skinability, enhancement)

Description

[Hixie (not reading bugmail)]

This covers the implementation of NS_THEME_PROGRESSBAR and
NS_THEME_PROGRESSBAR_CHUNK for XUL progress bars on Windows.

Query: how does NS_THEME_PROGRESSBAR_CHUNK know how big to be?

Comment 1

[David Hyatt]

Patch is coming.  There is a known issue with chunking in certain skins.  The
problem is that Windows XP lets you specify how to draw a background, e.g.,
either tiled or stretched.  In the case of Luna, chunks will be tiled, which
means I don't have to measure chunks; I can just pass the progress rect to the
theme API, and it will tile chunks into the rect provided.

Some skins, however, don't specify that chunks should be tiled, and to deal with
these I'm going to have to write my own little tiler that measures chunks and
tiles them into the progress rect.

Comment 2

[David Hyatt]

Attachment: Patch to clean up scrollbars and add progressbar support.

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 63582 [details] [diff] [review]
Patch to clean up scrollbars and add progressbar support.

r=bryner

Comment 4

[David Hyatt]

Attachment: Make some state constants generic and fix a bug with min-width/min-height in themes

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 63595 [details] [diff] [review]
Make some state constants generic and fix a bug with min-width/min-height in themes

r=bryner

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 63595 [details] [diff] [review]
Make some state constants generic and fix a bug with min-width/min-height in themes

sr=sspitzer

Comment 7

[David Hyatt]

Fixed.

Comment 8

[:deanis74]

Why were changes made to the modern theme, specifically progressmeter.css, in 
this patch?  This caused the cosmetic bug 140854.