117584 - NS_THEME_* implementations (meta bug)

Status: RESOLVED WONTFIX

(Core Graveyard :: Skinability, defect)

Description

[Hixie (not reading bugmail)]

Comment 1

[Hixie (not reading bugmail)]

hyatt: Why no NS_THEME_MENUBAR, NS_THEME_MENU_POPUP and NS_THEME_MENUITEM?

Comment 2

[David Hyatt]

There should be. Add bugs. :)

Comment 3

[Hixie (not reading bugmail)]

Ok, bug 118024 and bug 118025 filed. Note that those constants are not currently
defined. This might mean the Windows XP theme API does not have a way to get to
them, I don't know how you made the list.

Comment 4

[Mike Pinkerton (not reading bugmail)]

Attachment: mac osx progress

a screenshot of how far i've gotten on mac

Comment 5

[Ari]

I think we need a way to distinguish between simple push buttons that only
contain text and are of normal size and push buttons that are oversized or
contain icons. On the mac, the former corresponds to simple buttons and the
latter corresponds to bevel buttons.

Two buttons that should be bevel buttons on the mac are the 'Search' and 'M'
buttons in Navigator toolbar. This issue will become more important once xbl
form controls are implemented because buttons created with the input tag should
be regular buttons and buttons created with the button tag should be bevel buttons.

Comment 6

[Mike Pinkerton (not reading bugmail)]

yup, i totally agree. i've been thinking that for a while, just haven't done
anything about it ;)

Comment 7

[Stuart Ballard]

I'm not sure I like the claim that <input type="button" value="hello"> will look
different from <button>hello</button>. As a webdesigner (well, a programmer that
works on server-side web development and thus ends up writing a lot of website
code), that's not what I'd expect, and it'd be even more unexpected if windows
and/or linux made no such distinction.

Since I don't know much about OSX, I'm not sure how great of a difference there
is between the two button types, but I'd like to see some justification of the
claim that the two ways of creating buttons in html should look different (and
on mac only, even!).

Comment 8

[Mike Pinkerton (not reading bugmail)]

we're talking about chrome, not html ;)

Comment 9

[Ari]

Actually there is a precedent in the HTML standard for button elements being
drawn differently from input elements:

http://www.w3.org/TR/html4/interact/forms.html#h-17.5

"Visual user agents may render BUTTON buttons with relief and an up/down motion
when clicked, while they may render INPUT buttons as "flat" images."

Although button and input tags would not be distinguished in the way described
in the standard, they would be distinguished in a different way that is
consistent with the mac look and feel.

Comment 10

[Greg K.]

Do we need NS_THEME_* implementation for the activity icon? (The spinning arrows
seen on Modern's tabs during load, for example.)

Comment 11

[Greg K.]

*** Bug 74292 has been marked as a duplicate of this bug. ***

Comment 12

[Stuart Ballard]

Hmm, should bug 174471 be in the dependencies here?

Comment 13

[Erik Arvidsson]

How about adding helpwanted keyword here? Some of the remaining implementations
should be easy (just more of the same) and would greatly improve the UI.

I've been looking at the code and it seems like the menu part should be trivial
(WinXP). Mostly copy and paste. Unfortunately my Mozilla dev environment is
broken at the moment. I'll see if I can get it working anytime soon to see if
this is as easy as I think it is.

Comment 14

[Serge Gautherie (:sgautherie)]

Filter on "Nobody_NScomTLD_20080620"

Comment 15

[Gordon P. Hemsley [:GPHemsley]]

This bug has been buried in the graveyard and has not been updated in over 5 years. It is probably safe to assume that it will never be fixed, so resolving as WONTFIX.

[Mass-change filter: graveyard-wontfix-2014-09-24]