Closed
Bug 1157864
Opened 9 years ago
Closed 9 years ago
chromium sandbox: build on linux with musl libc (no <sys/cdefs.h>)
Categories
(Core :: Security: Process Sandboxing, defect)
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: felix.janda, Assigned: jld)
Details
Attachments
(2 files)
935 bytes,
patch
|
jld
:
review+
|
Details | Diff | Splinter Review |
1.31 KB,
patch
|
jld
:
review+
|
Details | Diff | Splinter Review |
Same problem as in https://bugzilla.mozilla.org/show_bug.cgi?id=1151202 with same simple fix (see attachment). The code seems to be kept in sync with upstream. So I have tried to submit it upstream https://code.google.com/p/chromium/issues/detail?id=463208 but it has gotten buried and I am not sure whether upstream cares. I would be happy for advice on how to proceed.
Assignee | ||
Comment 1•9 years ago
|
||
Sorry for losing track of this bug for so long. I've pushed the patch to the tryserver to double-check that it doesn't break any of the existing builds (especially B2G, because the Android headers are sometimes unexpectedly missing things): https://treeherder.mozilla.org/#/jobs?repo=try&revision=771103b7a27a The other thing that needs to happen is to list the patch in security/sandbox/modifications-to-chromium-to-reapply-after-upstream-merge.txt so that (as the filename suggests) we don't lose it the next time we import new upstream code, but I can take care of that. It'd also be nice if upstream would take it. Once the Try run comes back I'll try commenting on the upstream bug.
Assignee: nobody → jld
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8596768 [details] [diff] [review] Simple fix https://treeherder.mozilla.org/#/jobs?repo=try&revision=771103b7a27a passed (give or take some infrastructure problems that aren't this patch's fault).
Attachment #8596768 -
Flags: review+
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8637525 -
Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/1178c11561bc https://hg.mozilla.org/integration/mozilla-inbound/rev/7b7765684ee7
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1178c11561bc https://hg.mozilla.org/mozilla-central/rev/7b7765684ee7
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•