1157864 - chromium sandbox: build on linux with musl libc (no <sys/cdefs.h>)

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Felix Janda]

Attachment: Simple fix

Same problem as in

https://bugzilla.mozilla.org/show_bug.cgi?id=1151202

with same simple fix (see attachment).


The code seems to be kept in sync with upstream. So I have tried to submit it upstream

https://code.google.com/p/chromium/issues/detail?id=463208

but it has gotten buried and I am not sure whether upstream cares.


I would be happy for advice on how to proceed.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Sorry for losing track of this bug for so long.  I've pushed the patch to the tryserver to double-check that it doesn't break any of the existing builds (especially B2G, because the Android headers are sometimes unexpectedly missing things): https://treeherder.mozilla.org/#/jobs?repo=try&revision=771103b7a27a

The other thing that needs to happen is to list the patch in security/sandbox/modifications-to-chromium-to-reapply-after-upstream-merge.txt so that (as the filename suggests) we don't lose it the next time we import new upstream code, but I can take care of that.

It'd also be nice if upstream would take it.  Once the Try run comes back I'll try commenting on the upstream bug.

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8596768 [details] [diff] [review]
Simple fix

https://treeherder.mozilla.org/#/jobs?repo=try&revision=771103b7a27a passed (give or take some infrastructure problems that aren't this patch's fault).

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Patch to update the list of chromium patches

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1178c11561bc
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b7765684ee7

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1178c11561bc
https://hg.mozilla.org/mozilla-central/rev/7b7765684ee7