1157872 - puppet installs pull python packages from the pypi mirror

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

In bug 1154423, bhearsum saw installs via puppet running pip pulling from pypi.pvt.

Probably the easiest way to avoid this is to avoid parsing the config file, by setting PIP_CONFIG_FILE=/dev/null (https://pip.pypa.io/en/latest/user_guide.html#config-file)

Comment 1

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Attachment: MozReview Request: bz://1157872/grenade

/r/7731 - Bug 1157872: avoid parsing the config file

Pull down this commit:

hg pull -r 0dbde9eaf728bd13047df7f38df6472b80ed7f4c https://reviewboard-hg.mozilla.org/build-puppet

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8598518 [details]
MozReview Request: bz://1157872/grenade

https://reviewboard.mozilla.org/r/7729/#review6539

::: modules/python/manifests/virtualenv/package.pp:20
(Diff revision 1)
>      # if all of these fail; that can't hurt.

This comment identifies the problem, actually, and since it's no longer true it should be edited accordingly.

Ordinarily I'd say "good to push with that fixed", but let's see how the r- and re-review process works.

Comment 3

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Comment on attachment 8598518 [details]
MozReview Request: bz://1157872/grenade

/r/7731 - Bug 1157872: avoid parsing the config file
/r/7733 - Bug 1157872: put comment in context
/r/7743 - Bug 1157872: reworded comments

Pull down these commits:

hg pull -r c13f05ce5b278fc77c1b03841c68622a8c450f69 https://reviewboard-hg.mozilla.org/build-puppet

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8598518 [details]
MozReview Request: bz://1157872/grenade

https://reviewboard.mozilla.org/r/7729/#review6545

::: modules/python/manifests/virtualenv/package.pp:20
(Diff revision 2)
> -    # if all of these fail; that can't hurt.
> +    # if all of these fail.

I meant the other `;` -- "note that pip will fall back to the find-links options in .pip.conf" is no longer correct.

Comment 5

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Comment on attachment 8598518 [details]
MozReview Request: bz://1157872/grenade

/r/7731 - Bug 1157872: avoid parsing the config file
/r/7733 - Bug 1157872: put comment in context
/r/7743 - Bug 1157872: reworded comments
/r/7763 - Bug 1157872: more comment rewording

Pull down these commits:

hg pull -r fa6a0639919e994cd39eb6d1a865196317ff922c https://reviewboard-hg.mozilla.org/build-puppet

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8598518 [details]
MozReview Request: bz://1157872/grenade

https://reviewboard.mozilla.org/r/7729/#review6549

Comment 7

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Comment on attachment 8598518 [details]
MozReview Request: bz://1157872/grenade

https://reviewboard.mozilla.org/r/7729/#review6893

Ship It!

Comment 9

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Attachment: MozReview Request: Bug 1157872: more comment rewording

Comment 10

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Attachment: MozReview Request: Bug 1157872: avoid parsing the config file

Comment 11

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Attachment: MozReview Request: Bug 1157872: put comment in context

Comment 12

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Attachment: MozReview Request: Bug 1157872: reworded comments