Closed Bug 1157872 Opened 8 years ago Closed 8 years ago

puppet installs pull python packages from the pypi mirror

Categories

(Infrastructure & Operations :: RelOps: Puppet, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dustin, Assigned: grenade)

Details

Attachments

(4 files, 1 obsolete file)

In bug 1154423, bhearsum saw installs via puppet running pip pulling from pypi.pvt.

Probably the easiest way to avoid this is to avoid parsing the config file, by setting PIP_CONFIG_FILE=/dev/null (https://pip.pypa.io/en/latest/user_guide.html#config-file)
/r/7731 - Bug 1157872: avoid parsing the config file

Pull down this commit:

hg pull -r 0dbde9eaf728bd13047df7f38df6472b80ed7f4c https://reviewboard-hg.mozilla.org/build-puppet
Attachment #8598518 - Flags: review?(dustin)
Status: NEW → ASSIGNED
Comment on attachment 8598518 [details]
MozReview Request: bz://1157872/grenade

https://reviewboard.mozilla.org/r/7729/#review6539

::: modules/python/manifests/virtualenv/package.pp:20
(Diff revision 1)
>      # if all of these fail; that can't hurt.

This comment identifies the problem, actually, and since it's no longer true it should be edited accordingly.

Ordinarily I'd say "good to push with that fixed", but let's see how the r- and re-review process works.
Attachment #8598518 - Flags: review?(dustin)
Comment on attachment 8598518 [details]
MozReview Request: bz://1157872/grenade

/r/7731 - Bug 1157872: avoid parsing the config file
/r/7733 - Bug 1157872: put comment in context
/r/7743 - Bug 1157872: reworded comments

Pull down these commits:

hg pull -r c13f05ce5b278fc77c1b03841c68622a8c450f69 https://reviewboard-hg.mozilla.org/build-puppet
Attachment #8598518 - Flags: review?(dustin)
Comment on attachment 8598518 [details]
MozReview Request: bz://1157872/grenade

https://reviewboard.mozilla.org/r/7729/#review6545

::: modules/python/manifests/virtualenv/package.pp:20
(Diff revision 2)
> -    # if all of these fail; that can't hurt.
> +    # if all of these fail.

I meant the other `;` -- "note that pip will fall back to the find-links options in .pip.conf" is no longer correct.
Attachment #8598518 - Flags: review?(dustin)
Comment on attachment 8598518 [details]
MozReview Request: bz://1157872/grenade

/r/7731 - Bug 1157872: avoid parsing the config file
/r/7733 - Bug 1157872: put comment in context
/r/7743 - Bug 1157872: reworded comments
/r/7763 - Bug 1157872: more comment rewording

Pull down these commits:

hg pull -r fa6a0639919e994cd39eb6d1a865196317ff922c https://reviewboard-hg.mozilla.org/build-puppet
Attachment #8598518 - Flags: review?(dustin)
Attachment #8598518 - Flags: review?(dustin) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Attachment #8598518 - Flags: checked-in+
Comment on attachment 8598518 [details]
MozReview Request: bz://1157872/grenade

https://reviewboard.mozilla.org/r/7729/#review6893

Ship It!
Attachment #8598518 - Flags: review+
Attachment #8598518 - Attachment is obsolete: true
Attachment #8620143 - Flags: review+
Attachment #8620144 - Flags: review+
Attachment #8620145 - Flags: review+
Attachment #8620146 - Flags: review+
You need to log in before you can comment on or make changes to this bug.