Closed Bug 1158184 Opened 6 years ago Closed 6 years ago

Week 17 / April 24 - -Uplift github version of Readability/JSDOMParser into mozilla-central and aurora/beta

Categories

(Toolkit :: Reader Mode, defect)

defect
Not set
normal
Points:
1

Tracking

()

RESOLVED FIXED
mozilla40
Iteration:
40.2 - 27 Apr
Tracking Status
firefox38 --- wontfix
firefox38.0.5 --- fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1155692 +++

Per request from the sheriffs, one bug per uplift, so here's this week's edition of "let's update Readability.js"!
Flags: qe-verify-
Flags: in-testsuite-
Flags: firefox-backlog+
Approval Request Comment
[Feature/regressing bug #]: reader mode
[User impact if declined]: can't test reader mode changes
[Describe test coverage new/current, TreeHerder]: has basic tests, stringent tests in github
[Risks and why]: low risk; already disabled for 38.0 (but like this it's easily possible to test on the regular beta channel), otherwise restricted to reader mode so won't break anything else 
[String/UUID change made/needed]: nope
Attachment #8597341 - Flags: review+
Attachment #8597341 - Flags: approval-mozilla-release?
Attachment #8597341 - Flags: approval-mozilla-beta?
Attachment #8597341 - Flags: approval-mozilla-aurora?
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
NB: for uplift, please also uplift the testfix for the mobile testcase that this change... improved! (see comment #3)
https://hg.mozilla.org/mozilla-central/rev/c6e4ebeb0e69
https://hg.mozilla.org/mozilla-central/rev/137707995d3a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment on attachment 8597341 [details] [diff] [review]
Checked-in changes

We are late in the beta cycle. I would like to take it only for 38.0.5.
Attachment #8597341 - Flags: approval-mozilla-release?
Attachment #8597341 - Flags: approval-mozilla-release-
Attachment #8597341 - Flags: approval-mozilla-beta?
Attachment #8597341 - Flags: approval-mozilla-beta+
Attachment #8597341 - Flags: approval-mozilla-aurora?
Attachment #8597341 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.