1158184 - Week 17 / April 24 - -Uplift github version of Readability/JSDOMParser into mozilla-central and aurora/beta

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect)

Description

[:Gijs (he/him)]

+++ This bug was initially created as a clone of Bug #1155692 +++

Per request from the sheriffs, one bug per uplift, so here's this week's edition of "let's update Readability.js"!

Comment 1

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c6e4ebeb0e69

Comment 2

[:Gijs (he/him)]

Attachment: Checked-in changes

Approval Request Comment
[Feature/regressing bug #]: reader mode
[User impact if declined]: can't test reader mode changes
[Describe test coverage new/current, TreeHerder]: has basic tests, stringent tests in github
[Risks and why]: low risk; already disabled for 38.0 (but like this it's easily possible to test on the regular beta channel), otherwise restricted to reader mode so won't break anything else 
[String/UUID change made/needed]: nope

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/137707995d3a

Comment 4

[:Gijs (he/him)]

NB: for uplift, please also uplift the testfix for the mobile testcase that this change... improved! (see comment #3)

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c6e4ebeb0e69
https://hg.mozilla.org/mozilla-central/rev/137707995d3a

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8597341 [details] [diff] [review]
Checked-in changes

We are late in the beta cycle. I would like to take it only for 38.0.5.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9a81633dfeba
https://hg.mozilla.org/releases/mozilla-aurora/rev/48804a318b30

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f5387ac969be
https://hg.mozilla.org/releases/mozilla-beta/rev/d133698337aa