1158216 - Sync passwords

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, defect)

Description

[Richard Newman [:rnewman]]

Just another brick in the syncing wall.

Comment 1

[Richard Newman [:rnewman]]

Notes to self: 

* Some local timestamps are microseconds. Synced timestamps are all milliseconds.
* Only Android records will have timestamps. Desktops don't upload them yet. That means we need to handle missing ones.
* Furthermore, we have to handle records where our mirror record has *lost* fields.

Comment 2

[Richard Newman [:rnewman]]

Attachment: Pull req.

This needs rollup and more tests, but I think this is ready for review.

Comment 3

[Richard Newman [:rnewman]]

TODO: "httpRealm string: the HTTP Realm for which the login is valid. if not provided by the server, the value is the same as hostname"

Comment 4

[Richard Newman [:rnewman]]

Leaving my testing results:

* Added on iOS
* Added on desktop
* Modified on each
* Deleted on each
* Form fill works correctly on desktop
* Form fill is busted on iOS, but (a) it was busted before, and (b) I see that the DB is returning a matching row, so I'm confident that this is an issue in LoginHelper that we can fix separately.

Desktop UUIDs and iOS GUIDs work correctly on both platforms, it seems.

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8627190 [details] [review]
Pull req.

This looks pretty good. Do you have integration tests planned? I mean, tests where we hit the server from two client instances to see if they sync correctly? (I don't know if that is even possible, but I think that would be great to have on top of sync engines)

I see you silenced the sqlite compile warnings. Maybe move that to a separate PR or at least a separate commit? I created bug 1178795 for this.

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8627190 [details] [review]
Pull req.

Comments on GH, but nothing major.  The hard work was mostly in storage earlier -- bravo \o/

Comment 7

[Richard Newman [:rnewman]]

> This looks pretty good. Do you have integration tests planned? I mean, tests
> where we hit the server from two client instances to see if they sync
> correctly? (I don't know if that is even possible, but I think that would be
> great to have on top of sync engines)

I really want to do this, but it's a pretty big job -- basically implementing TPS for iOS. Not something we can do for v1, but it's an acknowledged chunk of debt.

Thanks, both of you, for the thorough review!

https://github.com/mozilla/firefox-ios/commit/4b655e915a9ec983c525aa38fc6d2de113d5c582