1158363 - Intermittent "TypeError: dump is not a function" in testTrackingProtection

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Description

[Geoff Brown [:gbrown]]

+++ This bug was initially created as a clone of Bug #1094649 +++

See https://bugzilla.mozilla.org/show_bug.cgi?id=1094649#c392. 

testTrackingProtection fails frequently on Android 4.3; "TypeError: dump is not a function" is found consistently in the failed logcat.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: comment out do_print calls

A crude but expedient solution!

It seems to me that dump is there generally (for checks and assertions) but can't be accessed (intermittently?) in the promise. Removing the do_print calls from the promise seems to allow this test to run reliably.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f73d824e524

Comment 2

[Geoff Brown [:gbrown]]

Comment on attachment 8597480 [details] [diff] [review]
comment out do_print calls

Review of attachment 8597480 [details] [diff] [review]:
-----------------------------------------------------------------

Retries on my try push eventually hit the same error. Maybe I was just lucky with the first few runs?

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8597480 [details] [diff] [review]
comment out do_print calls

Review of attachment 8597480 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this makes no sense.  do_print internally eventually gets to dump; if dump isn't working *nothing* will work, since that's the communication mechanism between the target device and the harness back on the host.  (Via Robocop:JS messages that make it to the log.)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4df354849629

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4df354849629

Comment 6

[Geoff Brown [:gbrown]]

This doesn't seem to be failing now:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c85e0f0f718b

I don't know why/what has changed.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1f006e649de3

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1f006e649de3