Closed Bug 1158363 Opened 6 years ago Closed 5 years ago

Intermittent "TypeError: dump is not a function" in testTrackingProtection

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 obsolete file)

+++ This bug was initially created as a clone of Bug #1094649 +++

See https://bugzilla.mozilla.org/show_bug.cgi?id=1094649#c392. 

testTrackingProtection fails frequently on Android 4.3; "TypeError: dump is not a function" is found consistently in the failed logcat.
Attached patch comment out do_print calls (obsolete) — Splinter Review
A crude but expedient solution!

It seems to me that dump is there generally (for checks and assertions) but can't be accessed (intermittently?) in the promise. Removing the do_print calls from the promise seems to allow this test to run reliably.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f73d824e524
Attachment #8597480 - Flags: review?(mark.finkle)
Blocks: 1158384
Comment on attachment 8597480 [details] [diff] [review]
comment out do_print calls

Review of attachment 8597480 [details] [diff] [review]:
-----------------------------------------------------------------

Retries on my try push eventually hit the same error. Maybe I was just lucky with the first few runs?
Attachment #8597480 - Flags: review?(mark.finkle)
Attachment #8597480 - Attachment is obsolete: true
Comment on attachment 8597480 [details] [diff] [review]
comment out do_print calls

Review of attachment 8597480 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this makes no sense.  do_print internally eventually gets to dump; if dump isn't working *nothing* will work, since that's the communication mechanism between the target device and the harness back on the host.  (Via Robocop:JS messages that make it to the log.)
Keywords: leave-open
Whiteboard: [test disabled on android 4.3]
Assignee: gbrown → nobody
Blocks: 1252961
This doesn't seem to be failing now:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c85e0f0f718b

I don't know why/what has changed.
Assignee: nobody → gbrown
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/1f006e649de3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Whiteboard: [test disabled on android 4.3]
You need to log in before you can comment on or make changes to this bug.