Closed
Bug 1158363
Opened 9 years ago
Closed 9 years ago
Intermittent "TypeError: dump is not a function" in testTrackingProtection
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: gbrown, Assigned: gbrown)
References
Details
Attachments
(1 obsolete file)
+++ This bug was initially created as a clone of Bug #1094649 +++
See https://bugzilla.mozilla.org/show_bug.cgi?id=1094649#c392.
testTrackingProtection fails frequently on Android 4.3; "TypeError: dump is not a function" is found consistently in the failed logcat.
Assignee | ||
Comment 1•9 years ago
|
||
A crude but expedient solution!
It seems to me that dump is there generally (for checks and assertions) but can't be accessed (intermittently?) in the promise. Removing the do_print calls from the promise seems to allow this test to run reliably.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f73d824e524
Attachment #8597480 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8597480 [details] [diff] [review]
comment out do_print calls
Review of attachment 8597480 [details] [diff] [review]:
-----------------------------------------------------------------
Retries on my try push eventually hit the same error. Maybe I was just lucky with the first few runs?
Attachment #8597480 -
Flags: review?(mark.finkle)
Assignee | ||
Updated•9 years ago
|
Attachment #8597480 -
Attachment is obsolete: true
Comment 3•9 years ago
|
||
Comment on attachment 8597480 [details] [diff] [review]
comment out do_print calls
Review of attachment 8597480 [details] [diff] [review]:
-----------------------------------------------------------------
Yeah, this makes no sense. do_print internally eventually gets to dump; if dump isn't working *nothing* will work, since that's the communication mechanism between the target device and the harness back on the host. (Via Robocop:JS messages that make it to the log.)
Assignee | ||
Updated•9 years ago
|
Keywords: leave-open
Whiteboard: [test disabled on android 4.3]
Comment 5•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Assignee: gbrown → nobody
Assignee | ||
Comment 6•9 years ago
|
||
This doesn't seem to be failing now:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c85e0f0f718b
I don't know why/what has changed.
Assignee: nobody → gbrown
Keywords: leave-open
Comment 8•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Assignee | ||
Updated•9 years ago
|
Whiteboard: [test disabled on android 4.3]
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•