1158388 - [NFC] Swiping up causes jerky, stuttered animation in the Shrinking UI.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-nfc-jerky-animation.txt

Description:
When swiping up on a piece of content to share via NFC, the content will animate in a very stuttered, jerky fashion

Repro Steps:
1) Update a Flame to 20150424010200
2) Enable NFC on the DUT, as well as on another device
3) Enter the Gallery app and select an image
4) Tap the back of the DUT to the back of the second device to enter the Shrinking UI
5) Slowly swipe up on the image

Actual:
The image card will animate in a jerky, stuttering fashion

Expected:
The image card will animate smoothly.

Environmental Variables:
Device: Flame 3.0 (512MB)(Full Flash)
Build ID: 20150424010200
Gaia: 0c5e2ee1173f3c53379ef3cd10de714836258fe8
Gecko: 22a157f7feb7
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Repro frequency: 10/10
See attached: Logcat, Video (URL)

Comment 1

[Martin Shuman [:Marty]]

This issue DOES occur on Flame 2.2, 2.1, and 2.0 builds.
The image card will animate in a jerky, stuttering fashion

Note: The issue seems less severe in 2.1 and 2.0 builds.

Environmental Variables:
Device: Flame 2.2 (512MB)(Full Flash)
Build ID: 20150424002507
Gaia: b838d0e7c163e66660dcb6e387d8339944a7a30e
Gecko: 5fe76b26e55f
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Environmental Variables:
Device: Flame 2.1 (512MB)(Full Flash)
Build ID: 20150424001201
Gaia: bbe983b4e8bebfec26b3726b79568a22d667223c
Gecko: 6a68a038146a
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Environmental Variables:
Device: Flame 2.0 (512MB)(Full Flash)
Build ID: 20150424000201
Gaia: 84898cadf28b1a1fcd03b726cff658de470282f0
Gecko: ff96615f8cfc
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 32.0 (2.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Peter Bylenga [:PBylenga]]

NI on component owner for nomination decision and assignment.

Comment 3

[Alison Shiue]

Do not nominate to block since this is not a functional bug.
Add gaia developers in CC list to aware this issue.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

ni? for Juwei on this.

This is a pretty bad UX, and the similar bugs have been identified as 2.1+. See Bug 997606 and Bug 1033136.

Comment 5

[Juwei Huang[:juwei]]

Hi,
Please do block this bug since it's a very bad experience.
People wouldn't be able to trust this function if it display choppy.

Comment 6

[Alison Shiue]

According to comment 5, nominate this issue.

Comment 7

[Vincent Chang[:vchang][changyihsin]]

Ni gaia developer and see if he can help to fix the problem.

Comment 8

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: will have George's input prior to making blocking decision.

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi Greg,
I deeply look into the code and found out that we we set timeout to update new position from touchmove event, it might cause the tilting screen doesn't follow user's finger just like this bug. I'm wondering why can't we simply follow the touchmove's movement exactly and transmit the file when the moving distance is over the threshold.

Comment 10

[Greg Weng [:snowmantw][:gweng][:λ]]

This is to prevent touch event fire too hurriedly and too sharply. If it can go smoother without that, and we can handle issues like queuing them, it's OK to remove the delay.

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] cctuan:1158388 > mozilla-b2g:master

Comment 12

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi Martin,
could you check if attachment 8603963 [details] [review]  works for you ? It looks fine on my device. Thanks.

Comment 13

[Martin Shuman [:Marty]]

This looks fine on my device as well. After checking attachment 8603963 [details] [review], the issue does appear to be fixed and the NFC Shrinking UI is animating smoothly.

Comment 14

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8603963 [details] [review]
[gaia] cctuan:1158388 > mozilla-b2g:master

Hi Greg,
since you're the original author of this part, could you review this patch for me?

Basically, I remain transitionDurtion as 0.3s when touchend but remove it while touchmove, and I also remove the setTimeout in touchmove handler.

Comment 15

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8603963 [details] [review]
[gaia] cctuan:1158388 > mozilla-b2g:master

Please add comments to explain what are you doing. It's important, since after 3 months we would have no idea what the code is doing without that, and thus workarounds get stockpiling.

Comment 16

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8603963 [details] [review]
[gaia] cctuan:1158388 > mozilla-b2g:master

Thanks Greg, comments are added, plz check again, thanks!

Comment 17

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: per comment 5. and it's kind of like regression per comment 1.

Comment 18

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8603963 [details] [review]
[gaia] cctuan:1158388 > mozilla-b2g:master

OK thanks.

Comment 19

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 20

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Per comment 19, could we just modify the "bug component" to System:window mgmt?

Comment 21

[(Inactive after June) George Duan [:gduan] [:喬智]]

manually land to master:
https://github.com/mozilla-b2g/gaia/commit/acc113371d6846c3f9208e0a7e1d92b093a9e8ff

Comment 22

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8603963 [details] [review]
[gaia] cctuan:1158388 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): It's not a regression for gaia, but it probably be a caused by some gecko's improvement for touchmove event.
[User impact] if declined: User might see the jerky animation like http://youtu.be/BXYi2laQDNg .
[Testing completed]: Yes, unit test and manual test
[Risk to taking this patch] (and alternatives if risky): None.
[String changes made]:

Comment 23

[Alison Shiue]

Verified on 3.0:
Build ID               20150513160203
Gaia Revision          338f66e6a96491d2f5854b188c6b141ceb690d97
Gaia Date              2015-05-13 14:08:45
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1fab94ad196c
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150513.193307
Firmware Date          Wed May 13 19:33:19 EDT 2015
Bootloader             L1TC100118D0

Comment 24

[Josh Cheng [:josh]]

Comment on attachment 8603963 [details] [review]
[gaia] cctuan:1158388 > mozilla-b2g:master

Approving and keep "verifyme" for 2.2

Comment 25

[(PTO June 19-July 7) Ryan VanderMeulen]

v2.2: https://github.com/mozilla-b2g/gaia/commit/37f83f99d5358820408b42c0444fa11fe1f4a738

Comment 26

[Shally Li（leave from Mozilla）]

This bug has been verified as pass on latest build of Flame v2.2 and Nexus 5 v2.2 by the STR in Comment 0.

Actual results: The image card is animate and smooth in Shrinking UI.
See attachment: verified_v2.2.mp4
Reproduce rate: 0/6


Device: Flame v2.2 build(Pass)
Build ID               20150519162501
Gaia Revision          63e9eeec3032318f8a240f80b6a184fa4b50b6e1
Gaia Date              2015-05-19 17:52:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4e078e1364d3
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150519.200807
Firmware Date          Tue May 19 20:08:18 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v2.2 build (Pass)
Build ID               20150519162501
Gaia Revision          63e9eeec3032318f8a240f80b6a184fa4b50b6e1
Gaia Date              2015-05-19 17:52:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4e078e1364d3
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150519.195445
Firmware Date          Tue May 19 19:55:01 EDT 2015
Bootloader             HHZ12f

---------------------------------------------
Leaving "verifyme" for v2.0&2.1 uplift & verification.

Comment 27

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.2.mp4