Add a favicon next to a tile's domain

NEW
Assigned to

Status

()

Firefox
New Tab Page
3 years ago
3 years ago

People

(Reporter: emtwo, Assigned: maxim zhilyaev)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 42
Points:
5
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: .?)

Updated

3 years ago
Blocks: 1140185
Iteration: --- → 40.3 - 11 May
Whiteboard: .?

Updated

3 years ago
Blocks: 1160372

Updated

3 years ago
No longer blocks: 1160372

Updated

3 years ago
No longer blocks: 1150228
Depends on: 1150228

Updated

3 years ago
Iteration: 40.3 - 11 May → 41.1 - May 25

Updated

3 years ago
Assignee: msamuel → nobody
Blocks: 1145418
No longer blocks: 1140185
Iteration: 41.1 - May 25 → ---

Comment 1

3 years ago
Could probably reuse what was done in bug 1163888 for unifiedcomplete to show the appropriate favicon for a host.
Depends on: 1163888
note that we only show existing icons, we don't fetch missing ones, also because with the new security policy regarding having a principal to load a favicon, we wouldn't know where to get the principal.

Updated

3 years ago
Blocks: 1172713
No longer blocks: 1145418

Updated

3 years ago
Blocks: 1192057
No longer blocks: 1172713

Updated

3 years ago
Assignee: nobody → mzhilyaev
Iteration: --- → 42.3 - Aug 10
Target Milestone: --- → Firefox 42
(Assignee)

Comment 3

3 years ago
This needs a bit more clarification. Aaron's comment here (https://bugzilla.mozilla.org/show_bug.cgi?id=1188015#c16) may suggest that we may want to attach a partner supplied favicon to the tile distribution spec like other tile images.   

I was under impression that we should be using browser favicon cache and display favicon for any tile which page has one.  

So, need clarification on expected functionality: browser cached favicons for all tiles, or a partner supplied favicon attached to tile distribution, or a mixture of both?
Flags: needinfo?(kghim)
Flags: needinfo?(athornburgh)

Comment 4

3 years ago
Is it possible/feasible to have a mixture both?

I don't want to limit the use of favicons, so browser cached versions are fine.

My question to you is whether those cached versions would be "official" by default, or "best guess".

However, I think partners would like to opportunity to update/change their favicon for Firefox users.
Flags: needinfo?(athornburgh)

Comment 5

3 years ago
Let's use browser favicon. We should try to minimize assets from clients as much as possible. If no favicon is available, show blank.
Flags: needinfo?(kghim)

Updated

3 years ago
Blocks: 1195113
(Assignee)

Comment 6

3 years ago
If we use browser favicon, then we are likely to show tiles ONLY for history tiles, because a user have visited landing URLs of history tiles already.  While the suggested or directory tiles URLs may miss a favicon, because a user is likely have not visited their landing pages. Which may result in a strange UX, where a user sees favicon for history tiles and sees none for suggested/directory tiles.

We could request a favicon for the landing URL host, but that would mean the site may learn about a user loading newtab with that tile being played, hence a privacy leak.

I recommend giving this nug a few more thought from product/UX perspective.
A proper fix would be adding a favicon to the distro of the tile.
Flags: needinfo?(kghim)

Comment 7

3 years ago
For History tiles, we'll get the favicon from the browser. 

For Suggested tiles, we can request a favicon file to load onto the distro.
Flags: needinfo?(kghim)

Updated

3 years ago
No longer blocks: 1195113
Iteration: 42.3 - Aug 10 → 43.1 - Aug 24
Points: --- → 2
(Assignee)

Updated

3 years ago
Points: 2 → 5

Updated

3 years ago
Blocks: 1202820

Updated

3 years ago
Blocks: 1204936
No longer blocks: 1192057

Updated

3 years ago
Blocks: 1192057
No longer blocks: 1202820, 1204936
You need to log in before you can comment on or make changes to this bug.