Closed Bug 1188015 Opened 4 years ago Closed 4 years ago

Tile Bottom Bar: Automatic Color

Categories

(Content Services Graveyard :: Tiles: Ops, defect)

defect
Not set
Points:
5

Tracking

(Not tracked)

RESOLVED FIXED
Iteration:
43.2 - Sep 7

People

(Reporter: ashonnard, Assigned: mzhilyaev)

References

(Blocks 3 open bugs)

Details

Attachments

(2 files)

Hey Mariana, 

I think you might be the right gal to bug for this, so if not, please pass me along!

The bottom bar of the Tile is NOT a part of the creative assets... that is generated by Firefox. (see attached, area called "website.com")

Can we choose a different color? 

-A
Hey Annalise, do you want to change the colour of the bottom bar to be the same for all tiles or different for every tile?

Right now they all have the same colour. If we want, we can allow clients to suggest a colour for the bar and this customization can be sent to Firefox via splice.

That would take a bit of work on both server and firefox.
love the way you spelled my name :) guess it serves me right for spelling your name wrong too!

We are only looking to change the color of the Yahoo content tile. Based on your note, will that only be possible via Splice? So looking like closer to November'15?

How much is a 'bit of work on both the server and firefox'? If this is too much to request than i'd like to nip it in the butt now, until we greater bandwidth
I know for Firefox it's not too bad, CC'd the server guys here to get their input.
I'm pretty sure the expression is "nip it in the BUD" ;)
(In reply to Aaron from comment #4)
> I'm pretty sure the expression is "nip it in the BUD" ;)

OH BOY...i've been saying that for years...sooo awkward...
I'll keep nipping things in their butts...(i am literally laughing so hard right now)
Hey team, 
just checking if this is a feasible quick fix as yahoo will be launching with our august 11th launch?
-A
Flags: needinfo?(msamuel)
This is not do-able by aug. 11th since that would require us to uplift changes to Firefox.
Flags: needinfo?(msamuel)
Moreover, while we're nipping it in the butt, I'm trying to understand the attached PDF.
It says the partner gives 3 assets. What are those?
(In reply to Olivier Yiptong [:oyiptong] from comment #8)
> Moreover, while we're nipping it in the butt, I'm trying to understand the
> attached PDF.
> It says the partner gives 3 assets. What are those?

History, Static, Rollover: these are all part of our standard spec docs!
Assignee: msamuel → mzhilyaev
Severity: critical → normal
Group: mozilla-employee-confidential
Blocks: 1192057
Need clarification of UX logic.
The partner specifies BG color for which situation:
- when we display static image?
- when rollover happens and we display rollover image?

I assume the color is for rollover display.
If so, should the partner specify a foreground color also?
What's the display logic here?
Flags: needinfo?(athornburgh)
Flags: needinfo?(ashonnard)
The display logic is:

Static = Partner Color

Rollover = Black (always, and without exception)

This way, the user presented with a branded static experience that leads to a consistent interactive experience that is familiar.

Rolling over to the partner color would be really confusing... That's definitely not what I had intended to communicate in the Style Guide.

-A
Flags: needinfo?(athornburgh)
Flags: needinfo?(ashonnard)
Noting relevant points from various conversations on this bug:

1. If the partner provides BG color only, than the default text color may look ugly. The partner needs to provide foreground-text color and background color for mouse out.  
2. But then what do we do for mouse in? Do we switch background and foreground?  Should the partner provide a pair of colors for mouse in display?  This needs clarification.
3. When favicon is added (bug# 1158856) it may look ugly on partner provided colors. Who verifies that the favicon looks OK?  Are we adding extra load on traffickers to verify every partner tile looks OK on mouse in and mouse out?
Flags: needinfo?(kghim)
Max,

1. We will ensure that the color a partner chooses provides sufficient contrast so that the site address bar text remains white for both static and rollover states. ONLY the bg color would change. Also, I won't let ugly colors make it through :)

2. No, the rollover color for any/all tile is BLACK. Always. Without exception.

3. I don't know about traffickers, but the favicon would be generated like any other... unless the client supplies us with an updated version we would approve.

Does these answer your questions?
> 1. We will ensure that the color a partner chooses provides sufficient
> contrast so that the site address bar text remains white for both static and
> rollover states. 

Currently, text color defaults to #5c5c5c (http://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/newtab/newTab.inc.css#156)  Are we changing it to white? Then what should be the default BG for tiles that do not have BG specified (like history tiles).

I guess I need this:

Mouse out - default color, default background.

> 2. No, the rollover color for any/all tile is BLACK. Always. Without
> exception.

Ok, default for rollover - color=white and background=black.


> 3. I don't know about traffickers, but the favicon would be generated like
> any other... unless the client supplies us with an updated version we would
> approve.

Sounds good.  We take whatever favicon the tile link has from the browser favicon cache.
My question was, do we need to insure that favicon looks OK on partner provided background (and on the black background on rollover).  Does this question make sense?
proposing JSON field for BF color:
{
  "id": "123",
  ....
  "bgColor": "#FF0055",
  ....
}

Requesting olivier's OK
Flags: needinfo?(oyiptong)
Max,

Your question (3.) is a good one. I recommend that we require partners to provide an SVG or 32x32 png of their most current favicon. This will ensure that the right, most quality version is shown for a custom title bar.

-A
Note that rollover color management will be done in Bug 1186596 - "Tile title bar enhancements"
This bug will ONLY set title background to partner provided.
Blocks: Sprint_CS_S1
Points: --- → 2
Flags: needinfo?(oyiptong)
(In reply to maxim zhilyaev from comment #15)
> proposing JSON field for BF color:
> {
>   "id": "123",
>   ....
>   "bgColor": "#FF0055",
>   ....
> }
> 
> Requesting olivier's OK

The Tile object already has a bgColor field. It is used for filling up the space surrounding the images.
We should use a new field for the title bar color
Flags: needinfo?(kghim)
Iteration: --- → 43.2 - Sep 7
Blocks: Sprint_CS_S2
Points: 2 → 5
(In reply to Olivier Yiptong [:oyiptong] from comment #18)

> The Tile object already has a bgColor field. It is used for filling up the
> space surrounding the images.
> We should use a new field for the title bar color

I will be using "titleBgColor"
Attachment #8655613 - Flags: review?(msamuel)
Comment on attachment 8655613 [details] [diff] [review]
v1.  dynamic settings of title bg color

Review of attachment 8655613 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/newtab/browser_newtab_1188015.js
@@ +1,1 @@
> +/* Any copyright is dedicated to the Public Domain.

Nit: can we call this file something else? Maybe browser_newtab_title_color.js? Just so it's easier to know what the test is about by reading the name and not having to look up the bug...
Attachment #8655613 - Flags: review?(msamuel) → review+
Blocks: 1205313
No longer blocks: 1205313
You need to log in before you can comment on or make changes to this bug.