1158900 - Editing bookmark's Location and Description in the Properties window doesn't work; bookmark title missing

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Ned Moore]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150427030207

Steps to reproduce:

Using an E10s or a non-E10s window:
Opening a Bookmark with right-click on Properties and then editing the Location/URL line and clicking Save - fails to the retain the edited change.


Actual results:

The location/URL is not changed/updated as edited


Expected results:

Location/URL should have accepted the edit.

Comment 1

[Gingerbread Man]

Additionally,

1. Changes to the Description field aren't saved either.

2. the window title says,
Properties for ""
— the actual bookmark title is missing.


Bug 951651 is the likely suspect.

Last good:
20150423030204 | https://hg.mozilla.org/mozilla-central/rev/0b202671c9e2

First bad:
20150424030204 | https://hg.mozilla.org/mozilla-central/rev/22a157f7feb7

Range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0b202671c9e2&tochange=22a157f7feb7

Comment 2

[Alice0775 White]

*Error in Browser Console when the Propriety Dialog pops up :

Use of Mutation Events is deprecated. Use MutationObserver instead. bookmarkProperties.js:316:0

*Error in Browser Console when click [Save] button:

NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.getBookmarkURI] PlacesUtils.jsm:3115:0

NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsITransactionManager.doTransaction] PlacesUtils.jsm:1967:0

Comment 3

[Marco Bonardo [:mak]]

the forst error is unrelated, was there before as well.

The second error is what matters here. I think all of the filed bugs about bookmarks edit being broken are duplicates of a single bug.

Comment 4

[Asaf Romano (gone)]

Attachment: patch.diff

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 8598470 [details] [diff] [review]
patch.diff

Review of attachment 8598470 [details] [diff] [review]:
-----------------------------------------------------------------

As I said in the other bug, please file a bug to add a test.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/90989388f197

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/90989388f197