1158553 - Star button / Edit Bookmark panel doesn't move the bookmark to the chosen folder

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

STR:
1. Create a new folder in Bookmarks Menu.
2. Create a new bookmark by star button (so it will be added to Unsorted Bookmarks).
3. Move it to the folder created before.
4. Being on bookmarked site edit it by star button and look on wrongly showed Folder localization.



Regression window (mozilla-inbound-win32)
Good:
https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win32/1429822861/

Bad:
https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win32/1429824241/

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2f2888ca42c2&tochange=2a1ddf08a4b4

Probably caused by:
Bug 951651 - Make bookmarkProperties, Star UI and Library info pane work with PlacesTransactions. r=mak



[Tracking Requested - why for this release]: Regression



@ Mano - Could you look on this issue?

Comment 3

[Gingerbread Man]

Localization is the process of translating and otherwise adapting a product for a particular locale.

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

awww... now I feel ashamed, silly me meant "location", not "localization"

Comment 5

[Asaf Romano (gone)]

Attachment: patch

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 8598456 [details] [diff] [review]
patch

Review of attachment 8598456 [details] [diff] [review]:
-----------------------------------------------------------------

We will take this as a quick fix since it's a widely used interface, but could you please file a separate bug to add a test for this functionality? It sounds bad we don't have any.

Also, looks like there other instances to fix:
mxr.mozilla.org/mozilla-central/search?string=_itemId&find=editBookmarkOverlay.js
I suppose these are causing bug 1158900.

Comment 7

[Marco Bonardo [:mak]]

http://mxr.mozilla.org/mozilla-central/search?string=_itemId&find=editBookmarkOverlay.js

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8103dd107052

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8103dd107052

Comment 10

[Helge Skjeveland]

Confirmed fixed as of 40.0a1 (2015-4-29)

Comment 11

[jen strickland :jenstrickland]

Since this bug is fixed, and verified it is fixed, I've removed the tracking flag.