115906 - Properties of card\other\notes - Enter make a line-wrap and close the card

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P3)

Description

[Tobias B. Besemer [:BesTo] (QA)]

Build: 2001-12-18-06

When I'm modifying the proberties of a adress-card and insert some text in
others\notes and press then the enter-key, moz make a line-wrap and close the card.
Moz should only make a line-wrap and don't close the card.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Sounds like <dialog> misuse

Comment 2

[Ninoschka Baca]

Trunk build 2001-12-18-03: WiMe
Interesting that it only happens when modifying an existing card, not when you 
first create the card.

Steps to reproduce:
1. Create a card (First, Last, Email Address, go to Other tab and type 3 
separate lines in the Notes area and notice that pressing Enter only moves the 
cursor to the next line as expected)
2. Close the card
3. With the card selected, click on the Properties button
4. Go to the Others tab
5. In the Notes area type some text and press Enter

Actual Results: The dialog closes
Expected Results: The cursor should advance to the next line and not close the 
dialog.

Comment 3

[Ninoschka Baca]

Marking nsbeta1 because pressing Enter shouldn't close the dialog. It makes it 
impossible to have several lines in the Notes section of an address card.

Comment 4

[racham]

Proberties->Properties (in the summary).

Comment 5

[Boris Zbarsky [:bzbarsky]]

*** Bug 117442 has been marked as a duplicate of this bug. ***

Comment 6

[jglick]

I'd like to see this fixed as well. As nbaca states, this makes it 
impossible to have several lines in the Notes section of an address card.

Comment 7

[Joe Infla]

Whenever this gets fixed, please note that Bug 113146 requires an identical fix
for the description field of a bookmark properties dialog. 

Comment 8

[Joseph Edward Miele]

If it is of any use to someone reading this, it is possible to enter multiple
lines of notes in an address card by using SHIFT-ENTER instead of just ENTER.

Comment 9

[Boris Zbarsky [:bzbarsky]]

*** Bug 117442 has been marked as a duplicate of this bug. ***

Comment 10

[Boris Zbarsky [:bzbarsky]]

*** Bug 139799 has been marked as a duplicate of this bug. ***

Comment 11

[(not reading, please use [e-mail] instead)]

working on a fix for this, coming to a trunk build soon.

Comment 12

[(not reading, please use [e-mail] instead)]

Attachment: fix, also fix the problem where the ok / cancel buttons are not aligned properly for the edit card dialog

Comment 13

[racham]

Comment on attachment 82288 [details] [diff] [review]
fix, also fix the problem where the ok / cancel buttons are not aligned properly for the edit card dialog

r=bhuvan

Comment 14

[David :Bienvenu]

Comment on attachment 82288 [details] [diff] [review]
fix, also fix the problem where the ok / cancel buttons are not aligned properly for the edit card dialog

sr=bienvenu

Comment 15

[(not reading, please use [e-mail] instead)]

fixed on trunk.  do we want this for RTM?

Comment 16

[(not reading, please use [e-mail] instead)]

nsbeta1- to nsbeta1, so we can decide if we want this for the next ns release.

Comment 17

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) for approval to checkin to the 1.0 branch, pending
Driver's approval (e.g. a= is older than 3 days) keyword.

Comment 18

[Ninoschka Baca]

Trunk build 2002-05-20: WinMe, Linux RH 7.1, Mac 10.1.3: Fixed
Marking Verified since the problem is fixed on the trunk.

Comment 19

[R.K.Aa.]

*** Bug 147205 has been marked as a duplicate of this bug. ***

Comment 20

[scottputterman]

changing to adt1.0.1+ for checkin to the 1.0 branch.  Please get drivers
approval before checking in.

Comment 21

[(not reading, please use [e-mail] instead)]

seting TM to 1.0.1

Comment 22

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 82288 [details] [diff] [review]
fix, also fix the problem where the ok / cancel buttons are not aligned properly for the edit card dialog

please check into the 1.0.1 branch ASAP. once landed remove the 
mozilla1.0.1+ keyword and add the fixed1.0.1 keyword

Comment 23

[(not reading, please use [e-mail] instead)]

fixed on trunk and branch.

Comment 24

[Ninoschka Baca]

Branch build 2002-06-11: WinMe
verified1.0.0