Closed Bug 1159190 Opened 5 years ago Closed 5 years ago

Add a commit hook which forbids mozL10n.get

Categories

(Firefox OS Graveyard :: Gaia, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stas, Unassigned)

Details

Attachments

(1 file)

As we're trying to reduce the number of mozL10n.get uses to zero (bug 1020138), it would be helpful to prevent using it in new code.

A commit hook might help.
Comment on attachment 8598607 [details] [review]
[gaia] stasm:1159190-commit-hook > mozilla-b2g:master

Julien, could you take a look a this?  I'm not quite sure whom to ask for the review.
Attachment #8598607 - Flags: review?(felash)
Attachment #8598607 - Flags: feedback?(gandalf)
Attachment #8598607 - Flags: feedback?(gandalf) → feedback+
Comment on attachment 8598607 [details] [review]
[gaia] stasm:1159190-commit-hook > mozilla-b2g:master

r=me with some nits

about creating a prefilled xfail.list, it's really up to you.

We should really reorganize this file, this starts to be not really readable... I can do that in bug 1094190 maybe :/
Attachment #8598607 - Flags: review?(felash) → review+
Keywords: checkin-needed
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
I merged manually:

https://github.com/mozilla-b2g/gaia/commit/e6c247f8ab1887648b878ce557dab0d275a334dd
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.