1159320 - --disable-webrtc builds now error out with "dom/ipc/PContent.ipdl:53: error: can't locate include file `PWebrtcGlobal.ipdl'"

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Daniel Holbert [:dholbert]]

Bug 1100502 added "include protocol PWebrtcGlobal;" to dom/ipc/PContent.ipdl, and now I hit this when building with ac_add_options --disable-webrtc:
{
 0:21.86   in file included from `$SRC/accessible/ipc/PDocAccessible.ipdl', line 7:
 0:21.86 $SRC/dom/ipc/PContent.ipdl:53: error: can't locate include file `PWebrtcGlobal.ipdl'
 0:21.89 Traceback (most recent call last):
 0:21.89   File "$SRC/config/pythonpath.py", line 56, in <module>
 0:21.89     main(sys.argv[1:])
 0:21.89   File "$SRC/config/pythonpath.py", line 48, in main
 0:21.89     execfile(script, frozenglobals)
 0:21.89   File "$SRC/ipc/ipdl/ipdl.py", line 132, in <module>
 0:21.89     if not ipdl.typecheck(ast):
 0:21.89   File "$SRC/ipc/ipdl/ipdl/__init__.py", line 35, in typecheck
 0:21.89     return TypeCheck().check(ast, errout)
 0:21.89   File "$SRC/ipc/ipdl/ipdl/type.py", line 616, in check
 0:21.89     if not runpass(GatherDecls(builtinUsing, self.errors)):
 0:21.89   File "$SRC/ipc/ipdl/ipdl/type.py", line 608, in runpass
 0:21.89     tu.accept(tcheckpass)
 0:21.89   File "$SRC/ipc/ipdl/ipdl/ast.py", line 139, in accept
 0:21.89     return visit(self)
 0:21.89   File "$SRC/ipc/ipdl/ipdl/type.py", line 731, in visitTranslationUnit
 0:21.89     if inc.tu.filetype == 'header':
 0:21.89 AttributeError: 'NoneType' object has no attribute 'filetype'
 0:22.02 Makefile:24: recipe for target 'export' failed
 0:22.02 make[5]: *** [export] Error 1
}

Comment 1

[Paul Kerr [:pkerr]]

Taking a look at this bug with a view to keep the new IPC stuff out of the disable-webrtc builds.

Comment 2

[Paul Kerr [:pkerr]]

Attachment: disable-webrtc builds fail after bug 1100502 applied

Comment 3

[Paul Kerr [:pkerr]]

I cannot drop an #ifdef in to an IPDL file. So, I moved around the necessary files that support the PWebrtcGlobal.ipdl to a branch of the source tree that was not disabled during a --disable-webrtc build. MOZ_WEBRTC is then used in the ContentParent.cpp and ContentChild.cpp to disable the creation of a WebRTC IPC pipeline.

Comment 4

[Paul Kerr [:pkerr]]

Are you able to provide a review for this patch?

Comment 5

[Daniel Holbert [:dholbert]]

You should probably ask someone with media or WebRTC knowledge to review.  (Thanks for the quick action coming up with a fix!)

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8598928 [details] [diff] [review]
disable-webrtc builds fail after bug 1100502 applied

Review of attachment 8598928 [details] [diff] [review]:
-----------------------------------------------------------------

moz.build changes need build-system peer

Comment 7

[Paul Kerr [:pkerr]]

Attachment: disable-webrtc builds fail after bug 1100502 applied

simplified version of first patch

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 8599390 [details] [diff] [review]
disable-webrtc builds fail after bug 1100502 applied

Review of attachment 8599390 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/ipc/ContentChild.cpp
@@ +120,5 @@
>  
>  #include "nsIScriptSecurityManager.h"
>  
> +#ifdef MOZ_WEBRTC
> +#include "mozilla/media/webrtc/WebrtcGlobalChild.h"

I don't get it. If you conditionally include this header and make the corresponding code conditional, why do you need to move the headers and ipdl?

Comment 9

[Paul Kerr [:pkerr]]

When building with -disable-webrtc, the media/webrtc/moz.build is not processed. Any EXPORT or IPDL statement found in that file will not be executed. So, the PWebrtcGlobal.ipdl is not flagged and the files expected when the "include protocol PWebrtcGlobal" that cannot be ifdef'ed out of PContent.ipdl will not be created. This causes the problem noted in the bug. I fixed that by moving the IPDL declaration into the dom/media/webrtc branch which holds components that are shared between media and webrtc. (I moved the PWebrtcGlobal.ipdl file simply to have it reside in the same branch where the moz.build managed.)

This fixed the first problem but raised the second: the file WebrtcGlobal.h is imported directly into PWebrtcGlobal.ipdl to provide the data serialization definitions. I moved its EXPORT statement to dom/media/moz.build along with moving the file to dom/media/webrtc. This allowed the IPDL tools to generated the necessary files to fix the error with further propagation stopped by the #ifdef MOZ_WEBRTC lines added to the PContentParent.cpp and PContentChild.cpp files.

Is there a way to have part of the media/webrtc/moz.build file processed when -disable-webrtc is set?

Comment 10

[Landry Breuil (:gaston)]

Fwiw, also hitting this on NetBSD/amd64 using --disable-webrtc and OpenBSD/sparc64 (where webrtc is not enabled)

http://buildbot.rhaalovely.net/builders/mozilla-central-netbsd-amd64/builds/109/steps/build/logs/stdio
http://buildbot.rhaalovely.net/builders/mozilla-central-sparc64/builds/1051/steps/build/logs/stdio

Comment 11

[Paul Kerr [:pkerr]]

see comment 9.

Comment 12

[Mike Hommey [:glandium]]

Comment on attachment 8599390 [details] [diff] [review]
disable-webrtc builds fail after bug 1100502 applied

Review of attachment 8599390 [details] [diff] [review]:
-----------------------------------------------------------------

Considering comment 9, I guess this is reasonable, although some webrtc peer should probably take a look. That being said, I don't understand why ipdl aren't preprocessed, which would make this so much easier...

Comment 13

[Paul Kerr [:pkerr]]

Attachment: disable-webrtc builds fail after bug 1100502 applied

Comment 14

[Paul Kerr [:pkerr]]

Comment on attachment 8601844 [details] [diff] [review]
disable-webrtc builds fail after bug 1100502 applied

Carry forward rjesup r+

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d384c358563

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0d384c358563