Closed
Bug 1408716
Opened 7 years ago
Closed 7 years ago
Remove dynamic_cast from about:webrtc code
Categories
(Core :: WebRTC, enhancement, P3)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: jesup, Assigned: jesup)
References
Details
Attachments
(1 file)
|
1.04 KB,
patch
|
drno
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1100502 +++
bz noted we're using dynamic_cast in WebrtcGlobal.h - we don't need to be.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8918612 -
Flags: review?(drno)
|
|
Assignee | |
Comment 2•7 years ago
|
||
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8918612 [details] [diff] [review]
Remove unneeded dynamic_cast
Review of attachment 8918612 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #8918612 -
Flags: review?(drno) → review+
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a08038db2c18
Remove unneeded dynamic_cast r=drno
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•