Don't automatically set prelim review queue for unlisted add-on on failed validation

VERIFIED FIXED in 2015-05

Status

addons.mozilla.org Graveyard
Admin/Editor Tools
VERIFIED FIXED
3 years ago
2 years ago

People

(Reporter: magopian, Assigned: robhudson)

Tracking

unspecified
2015-05

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Created attachment 8599300 [details]
Screen Shot 2015-04-29 at 15.31.21.png

We don't want to be in a position where developers not reading the text on the page would submit their add-on automatically to the unlisted prelim review queue if their add-on fails automatic validation.

What we want instead is a way to make sure the developer explicitly chooses to submit it to the prelim review queue by either showing a popup, or display an empty checkbox labeled "I want to submit this file through a manual review" that will need to be checked to enable the big blue "continue" button.

This same confirmation will be needed for new versions or files.
(Assignee)

Comment 1

3 years ago
PR: https://github.com/mozilla/olympia/pull/548
Assignee: nobody → robhudson.mozbugs
(Assignee)

Comment 2

3 years ago
https://github.com/mozilla/olympia/commit/ea10b8f61bde5a19114f62be21201fc0175cdba2
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 3

3 years ago
Verified as fixed in FF38(Win7) in addons-dev.allizom.org
Postfix screncast: http://screencast.com/t/L4HsaRAnekh
Closing bug.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.