Closed Bug 1159775 Opened 10 years ago Closed 10 years ago

Port |Bug 870891 - Move DIST_FILES to moz.build| to comm-central

Categories

(MailNews Core :: Build Config, defect)

Product:
MailNews Core
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox40 affected)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 40.0
Tracking Flags:
Tracking Status
firefox40 --- affected

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

Attachments

(5 files, 1 obsolete file)

Calendar port [Checked in: Comment 13]
4.47 KB, patch
Fallen
: review+
Details | Diff | Splinter Review
SeaMonkey port [Checked in: Comment 9]
2.21 KB, patch
neil
: review+
Details | Diff | Splinter Review
Instantbird port [Checked in: Comment 7]
1.07 KB, patch
clokep
: review+
Details | Diff | Splinter Review
Use EXTRA_PP_COMPONENTS for Calendar [Checked in: Comment 17]
1.06 KB, patch
Fallen
: review+
Details | Diff | Splinter Review
Thunderbird port with no theme changes [Checked in: Comment 18]
1.46 KB, patch
rkent
: review+
Details | Diff | Splinter Review
Bug 870891 moved DIST_FILES from Makefile.in to moz.build on mozilla-central, the same should be done for comm-central
Attachment #8599384 - Flags: review?(philipp)
Attached patch Thunderbird port (obsolete) — — Splinter Review
Attachment #8599386 - Flags: review?(Pidgeot18)
Attachment #8599387 - Flags: review?(neil)
Attachment #8599388 - Flags: review?(clokep)
Attachment #8599387 - Flags: review?(neil) → review+
Comment on attachment 8599388 [details] [diff] [review] Instantbird port [Checked in: Comment 7] Thank you! :)
Attachment #8599388 - Flags: review?(clokep) → review+
Comment on attachment 8599384 [details] [diff] [review] Calendar port [Checked in: Comment 13] Review of attachment 8599384 [details] [diff] [review]: ----------------------------------------------------------------- Hmm so DIST_FILES preprocesses the files afaik, maybe we can simplify some stuff this way. In calendar/base/backend/libical/build/Makefile.in can you try removing the libs target, and putting this into moz.build: DIST_FILES.components += [ 'libical-manifest' ] As a result, the libical-manifest should be copied to the dist/xpi-stage/components/libical-manifest and be preprocessed. Make sure to remove the file before you attempt to have it copied to make sure its updated. If that doesn't work, r+ nevertheless.
Attachment #8599384 - Flags: review?(philipp) → review+
Comment on attachment 8599388 [details] [diff] [review] Instantbird port [Checked in: Comment 7] https://hg.mozilla.org/comm-central/rev/b831d31b8821
Attachment #8599388 - Attachment description: Instantbird port → Instantbird port [Checked in: Comment 7]
Comment on attachment 8599387 [details] [diff] [review] SeaMonkey port [Checked in: Comment 9] a=me CLOSED TREE
Comment on attachment 8599387 [details] [diff] [review] SeaMonkey port [Checked in: Comment 9] http://hg.mozilla.org/comm-central/rev/71d8771ae203
Attachment #8599387 - Attachment description: SeaMonkey port → SeaMonkey port [Checked in: Comment 9]
DIST_FILES does not deal with subdirectories, but there is EXTRA_PP_COMPONENTS which does pre-process files into the components subdirectory.
Attachment #8603818 - Flags: review?(philipp)
I've removed the theme changes as they are now covered in bug 1163441
Attachment #8599386 - Attachment is obsolete: true
Attachment #8599386 - Flags: review?(Pidgeot18)
Attachment #8603886 - Flags: review?(Pidgeot18)
Can you do a try build with this patch? I think I tried to use EXTRA_PP_COMPONENTS in the past, but since its usually used for actual components, it threw some error about missing a manifest entry or something.
Flags: needinfo?(iann_bugzilla)
Comment on attachment 8599384 [details] [diff] [review] Calendar port [Checked in: Comment 13] https://hg.mozilla.org/comm-central/rev/856553fccd61
Attachment #8599384 - Attachment description: Calendar port → Calendar port [Checked in: Comment 13]
Comment on attachment 8603818 [details] [diff] [review] Use EXTRA_PP_COMPONENTS for Calendar [Checked in: Comment 17] Try build looks good, r=philipp
Attachment #8603818 - Flags: review?(philipp) → review+
Comment on attachment 8603886 [details] [diff] [review] Thunderbird port with no theme changes [Checked in: Comment 18] Review of attachment 8603886 [details] [diff] [review]: ----------------------------------------------------------------- Joshua still seems to be tied up with his research project, so let me r+ this simple change.
Attachment #8603886 - Flags: review?(Pidgeot18) → review+
Comment on attachment 8603818 [details] [diff] [review] Use EXTRA_PP_COMPONENTS for Calendar [Checked in: Comment 17] https://hg.mozilla.org/comm-central/rev/9ae077f0b6bb
Attachment #8603818 - Attachment description: Use EXTRA_PP_COMPONENTS for Calendar → Use EXTRA_PP_COMPONENTS for Calendar [Checked in: Comment 17]
Comment on attachment 8603886 [details] [diff] [review] Thunderbird port with no theme changes [Checked in: Comment 18] https://hg.mozilla.org/comm-central/rev/cf486fa6264b
Attachment #8603886 - Attachment description: Thunderbird port with no theme changes → Thunderbird port with no theme changes [Checked in: Comment 18]
Flags: needinfo?(iann_bugzilla)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: