The default bug view has changed. See this FAQ.

Port |Bug 870891 - Move DIST_FILES to moz.build| to comm-central

RESOLVED FIXED in Thunderbird 40.0

Status

MailNews Core
Build Config
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Trunk
Thunderbird 40.0

Firefox Tracking Flags

(firefox40 affected)

Details

Attachments

(5 attachments, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Bug 870891 moved DIST_FILES from Makefile.in to moz.build on mozilla-central, the same should be done for comm-central
(Assignee)

Comment 1

2 years ago
Created attachment 8599384 [details] [diff] [review]
Calendar port [Checked in: Comment 13]
Attachment #8599384 - Flags: review?(philipp)
(Assignee)

Comment 2

2 years ago
Created attachment 8599386 [details] [diff] [review]
Thunderbird port
Attachment #8599386 - Flags: review?(Pidgeot18)
(Assignee)

Comment 3

2 years ago
Created attachment 8599387 [details] [diff] [review]
SeaMonkey port [Checked in: Comment 9]
Attachment #8599387 - Flags: review?(neil)
(Assignee)

Comment 4

2 years ago
Created attachment 8599388 [details] [diff] [review]
Instantbird port [Checked in: Comment 7]
Attachment #8599388 - Flags: review?(clokep)

Updated

2 years ago
Attachment #8599387 - Flags: review?(neil) → review+
Comment on attachment 8599388 [details] [diff] [review]
Instantbird port [Checked in: Comment 7]

Thank you! :)
Attachment #8599388 - Flags: review?(clokep) → review+
Comment on attachment 8599384 [details] [diff] [review]
Calendar port [Checked in: Comment 13]

Review of attachment 8599384 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm so DIST_FILES preprocesses the files afaik, maybe we can simplify some stuff this way.

In calendar/base/backend/libical/build/Makefile.in can you try removing the libs target, and putting this into moz.build:

DIST_FILES.components += [ 'libical-manifest' ]

As a result, the libical-manifest should be copied to the dist/xpi-stage/components/libical-manifest and be preprocessed. Make sure to remove the file before you attempt to have it copied to make sure its updated.

If that doesn't work, r+ nevertheless.
Attachment #8599384 - Flags: review?(philipp) → review+
(Assignee)

Comment 7

2 years ago
Comment on attachment 8599388 [details] [diff] [review]
Instantbird port [Checked in: Comment 7]

https://hg.mozilla.org/comm-central/rev/b831d31b8821
Attachment #8599388 - Attachment description: Instantbird port → Instantbird port [Checked in: Comment 7]

Comment 8

2 years ago
Comment on attachment 8599387 [details] [diff] [review]
SeaMonkey port [Checked in: Comment 9]

a=me CLOSED TREE
(Assignee)

Comment 9

2 years ago
Comment on attachment 8599387 [details] [diff] [review]
SeaMonkey port [Checked in: Comment 9]

http://hg.mozilla.org/comm-central/rev/71d8771ae203
Attachment #8599387 - Attachment description: SeaMonkey port → SeaMonkey port [Checked in: Comment 9]
(Assignee)

Comment 10

2 years ago
Created attachment 8603818 [details] [diff] [review]
Use EXTRA_PP_COMPONENTS for Calendar [Checked in: Comment 17]

DIST_FILES does not deal with subdirectories, but there is EXTRA_PP_COMPONENTS which does pre-process files into the components subdirectory.
Attachment #8603818 - Flags: review?(philipp)
(Assignee)

Comment 11

2 years ago
Created attachment 8603886 [details] [diff] [review]
Thunderbird port with no theme changes [Checked in: Comment 18]

I've removed the theme changes as they are now covered in bug 1163441
Attachment #8599386 - Attachment is obsolete: true
Attachment #8599386 - Flags: review?(Pidgeot18)
Attachment #8603886 - Flags: review?(Pidgeot18)
Can you do a try build with this patch? I think I tried to use EXTRA_PP_COMPONENTS in the past, but since its usually used for actual components, it threw some error about missing a manifest entry or something.
Flags: needinfo?(iann_bugzilla)
(Assignee)

Comment 13

2 years ago
Comment on attachment 8599384 [details] [diff] [review]
Calendar port [Checked in: Comment 13]

https://hg.mozilla.org/comm-central/rev/856553fccd61
Attachment #8599384 - Attachment description: Calendar port → Calendar port [Checked in: Comment 13]
(Assignee)

Comment 14

2 years ago
Pushed to try:
https://hg.mozilla.org/try-comm-central/pushloghtml?changeset=2f68b4374ac0
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=2f68b4374ac0
Comment on attachment 8603818 [details] [diff] [review]
Use EXTRA_PP_COMPONENTS for Calendar [Checked in: Comment 17]

Try build looks good, r=philipp
Attachment #8603818 - Flags: review?(philipp) → review+

Comment 16

2 years ago
Comment on attachment 8603886 [details] [diff] [review]
Thunderbird port with no theme changes [Checked in: Comment 18]

Review of attachment 8603886 [details] [diff] [review]:
-----------------------------------------------------------------

Joshua still seems to be tied up with his research project, so let me r+ this simple change.
Attachment #8603886 - Flags: review?(Pidgeot18) → review+
(Assignee)

Comment 17

2 years ago
Comment on attachment 8603818 [details] [diff] [review]
Use EXTRA_PP_COMPONENTS for Calendar [Checked in: Comment 17]

https://hg.mozilla.org/comm-central/rev/9ae077f0b6bb
Attachment #8603818 - Attachment description: Use EXTRA_PP_COMPONENTS for Calendar → Use EXTRA_PP_COMPONENTS for Calendar [Checked in: Comment 17]
(Assignee)

Comment 18

2 years ago
Comment on attachment 8603886 [details] [diff] [review]
Thunderbird port with no theme changes [Checked in: Comment 18]

https://hg.mozilla.org/comm-central/rev/cf486fa6264b
Attachment #8603886 - Attachment description: Thunderbird port with no theme changes → Thunderbird port with no theme changes [Checked in: Comment 18]
Flags: needinfo?(iann_bugzilla)
(Assignee)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
You need to log in before you can comment on or make changes to this bug.