Do not use DIST_SUBDIR for Thunderbird themes

ASSIGNED
Assigned to

Status

Thunderbird
Theme
ASSIGNED
3 years ago
2 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

3 years ago
Created attachment 8603885 [details] [diff] [review]
Port changes to Thunderbird

This ports:
Theme specific parts for Bug 870891 - Move DIST_FILES to moz.build
Bug 1137364 - part 2 - move browser themes icon installation to FINAL_TARGET_FILES
Attachment #8603885 - Flags: review?(bwinton)
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Attachment #8603885 - Flags: review?(bwinton)
(Assignee)

Comment 1

3 years ago
Created attachment 8606220 [details] [diff] [review]
Use FINAL_TARGET_FILES and PP_TARGETS

So, from the discussion over in Bug 1163442, using DIST_FILES and DIST_SUBDIR changes what is put where when building themes.
Prior to landing of part 3 from Bug 957220, theme chrome files would end up in dist/bin/chrome (and classic subdirectory), after they would be in dist/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}
Part of this patch restores the location by using PP_TARGETS and removes the use of DIST_FILES and DIST_SUBDIR
The other part is making use of FINAL_TARGETS_FILES and removing duplication within Makefile.in/moz.build files.
Attachment #8606220 - Flags: review?(Pidgeot18)
(Assignee)

Updated

3 years ago
Attachment #8603885 - Attachment is obsolete: true
This is just a dupe of bug 1138063, isn't it?
(Assignee)

Comment 3

2 years ago
(In reply to Joshua Cranmer [:jcranmer] from comment #2)
> This is just a dupe of bug 1138063, isn't it?

In parts (see comment #1), but it goes further in some places (e.g. removes moz.build files under OS subdirectories under mail/themes) and fixes the issue of DIST_FILES not doing the right thing for themes and having to use PP_TARGETS instead (bug title now corrected like it was for bug 1163442).
Summary: Use FINAL_TARGET_FILES and DIST_FILES for Thunderbird themes → Use FINAL_TARGET_FILES and PP_TARGETS (instead of DIST_FILES) for Thunderbird themes
(Assignee)

Comment 4

2 years ago
Created attachment 8639083 [details] [diff] [review]
Use FINAL_TARGET_FILES and PP_TARGETS v2

Rebased after landing of fix from bug 1138063
Attachment #8606220 - Attachment is obsolete: true
Attachment #8606220 - Flags: review?(Pidgeot18)
Attachment #8639083 - Flags: review?(Pidgeot18)

Updated

2 years ago
Depends on: 1230960, 1229419
(Assignee)

Updated

2 years ago
Summary: Use FINAL_TARGET_FILES and PP_TARGETS (instead of DIST_FILES) for Thunderbird themes → Do not use DIST_SUBDIR for Thunderbird themes
(Assignee)

Comment 5

2 years ago
Created attachment 8715098 [details] [diff] [review]
Remove use of DIST_SUBDIR
Attachment #8639083 - Attachment is obsolete: true
Attachment #8639083 - Flags: review?(Pidgeot18)
You need to log in before you can comment on or make changes to this bug.