1163441 - Do not use DIST_SUBDIR for Thunderbird themes

Status: RESOLVED INVALID

(Thunderbird :: Theme, defect)

Description

[Ian Neal]

Attachment: Port changes to Thunderbird

This ports:
Theme specific parts for Bug 870891 - Move DIST_FILES to moz.build
Bug 1137364 - part 2 - move browser themes icon installation to FINAL_TARGET_FILES

Comment 1

[Ian Neal]

Attachment: Use FINAL_TARGET_FILES and PP_TARGETS

So, from the discussion over in Bug 1163442, using DIST_FILES and DIST_SUBDIR changes what is put where when building themes.
Prior to landing of part 3 from Bug 957220, theme chrome files would end up in dist/bin/chrome (and classic subdirectory), after they would be in dist/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}
Part of this patch restores the location by using PP_TARGETS and removes the use of DIST_FILES and DIST_SUBDIR
The other part is making use of FINAL_TARGETS_FILES and removing duplication within Makefile.in/moz.build files.

Comment 2

[Joshua Cranmer [:jcranmer]]

This is just a dupe of bug 1138063, isn't it?

Comment 3

[Ian Neal]

(In reply to Joshua Cranmer [:jcranmer] from comment #2)
> This is just a dupe of bug 1138063, isn't it?

In parts (see comment #1), but it goes further in some places (e.g. removes moz.build files under OS subdirectories under mail/themes) and fixes the issue of DIST_FILES not doing the right thing for themes and having to use PP_TARGETS instead (bug title now corrected like it was for bug 1163442).

Comment 4

[Ian Neal]

Attachment: Use FINAL_TARGET_FILES and PP_TARGETS v2

Rebased after landing of fix from bug 1138063

Comment 5

[Ian Neal]

Attachment: Remove use of DIST_SUBDIR

Comment 6

[Wayne Mery (:wsmwk)]

still wanted?

Comment 7

[Rob Lemley [:rjl]]

Doesn't appear to be relevant anymore?

Comment 8

[Wayne Mery (:wsmwk)]

Please reopen if this is still needed.