Open Bug 1163441 Opened 5 years ago Updated 4 years ago

Do not use DIST_SUBDIR for Thunderbird themes

Categories

(Thunderbird :: Theme, defect)

defect
Not set

Tracking

(Not tracked)

ASSIGNED

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

Attachments

(1 file, 3 obsolete files)

Attached patch Port changes to Thunderbird (obsolete) — Splinter Review
This ports:
Theme specific parts for Bug 870891 - Move DIST_FILES to moz.build
Bug 1137364 - part 2 - move browser themes icon installation to FINAL_TARGET_FILES
Attachment #8603885 - Flags: review?(bwinton)
Status: NEW → ASSIGNED
Attachment #8603885 - Flags: review?(bwinton)
So, from the discussion over in Bug 1163442, using DIST_FILES and DIST_SUBDIR changes what is put where when building themes.
Prior to landing of part 3 from Bug 957220, theme chrome files would end up in dist/bin/chrome (and classic subdirectory), after they would be in dist/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}
Part of this patch restores the location by using PP_TARGETS and removes the use of DIST_FILES and DIST_SUBDIR
The other part is making use of FINAL_TARGETS_FILES and removing duplication within Makefile.in/moz.build files.
Attachment #8606220 - Flags: review?(Pidgeot18)
Attachment #8603885 - Attachment is obsolete: true
This is just a dupe of bug 1138063, isn't it?
(In reply to Joshua Cranmer [:jcranmer] from comment #2)
> This is just a dupe of bug 1138063, isn't it?

In parts (see comment #1), but it goes further in some places (e.g. removes moz.build files under OS subdirectories under mail/themes) and fixes the issue of DIST_FILES not doing the right thing for themes and having to use PP_TARGETS instead (bug title now corrected like it was for bug 1163442).
Summary: Use FINAL_TARGET_FILES and DIST_FILES for Thunderbird themes → Use FINAL_TARGET_FILES and PP_TARGETS (instead of DIST_FILES) for Thunderbird themes
Rebased after landing of fix from bug 1138063
Attachment #8606220 - Attachment is obsolete: true
Attachment #8606220 - Flags: review?(Pidgeot18)
Attachment #8639083 - Flags: review?(Pidgeot18)
Depends on: 1230960, 1229419
Summary: Use FINAL_TARGET_FILES and PP_TARGETS (instead of DIST_FILES) for Thunderbird themes → Do not use DIST_SUBDIR for Thunderbird themes
Attachment #8639083 - Attachment is obsolete: true
Attachment #8639083 - Flags: review?(Pidgeot18)
You need to log in before you can comment on or make changes to this bug.