Closed
Bug 1159840
Opened 9 years ago
Closed 9 years ago
Remove libvpx alignment patch
Categories
(Core :: WebRTC, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: rillian, Assigned: rillian)
References
Details
Attachments
(1 file)
2.40 KB,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
Follow-up testing in bug 1137614 suggests that the crash in vp8_diamond_search_sadx4 was caused by unified build breakage. If so, we should be able to remove the DECLARE_ALIGNED hack patch, now that we've switched to building libvpx non-unified in bug 1148639.
Assignee | ||
Comment 1•9 years ago
|
||
Ok with you, David?
Assignee: nobody → giles
Attachment #8599426 -
Flags: review?(kinetik)
Attachment #8599426 -
Flags: feedback?(dmajor)
Comment on attachment 8599426 [details] [diff] [review] Remove alignment hack I suspect that the underlying cause may still be there. Out of curiosity, can you elaborate on the libvpx developer's reasoning for why this is caused by unification? I won't stop you from trying, but please keep an eye on crash-stats afterward.
Attachment #8599426 -
Flags: feedback?(dmajor)
Updated•9 years ago
|
Attachment #8599426 -
Flags: review?(kinetik) → review+
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to David Major [:dmajor] from comment #2) > I suspect that the underlying cause may still be there. With good reason, but I'd like to verify or be able to report upstream. > Out of curiosity, > can you elaborate on the libvpx developer's reasoning for why this is caused > by unification? No. The game of telephone didn't include those nuances. > I won't stop you from trying, but please keep an eye on crash-stats > afterward. I'm not sure how to do that. Can you show me, or report whether issues show up over the weekend?
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/95b41029d775
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•