1159840 - Remove libvpx alignment patch

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Ralph Giles (:rillian)]

Follow-up testing in bug 1137614 suggests that the crash in vp8_diamond_search_sadx4 was caused by unified build breakage. If so, we should be able to remove the DECLARE_ALIGNED hack patch, now that we've switched to building libvpx non-unified in bug 1148639.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Remove alignment hack

Ok with you, David?

Comment 2

[(Away)]

Comment on attachment 8599426 [details] [diff] [review]
Remove alignment hack

I suspect that the underlying cause may still be there. Out of curiosity, can you elaborate on the libvpx developer's reasoning for why this is caused by unification?

I won't stop you from trying, but please keep an eye on crash-stats afterward.

Comment 3

[Ralph Giles (:rillian)]

(In reply to David Major [:dmajor] from comment #2)

> I suspect that the underlying cause may still be there.

With good reason, but I'd like to verify or be able to report upstream.

> Out of curiosity,
> can you elaborate on the libvpx developer's reasoning for why this is caused
> by unification?

No. The game of telephone didn't include those nuances.

> I won't stop you from trying, but please keep an eye on crash-stats
> afterward.

I'm not sure how to do that. Can you show me, or report whether issues show up over the weekend?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95b41029d775

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/95b41029d775

Comment 6

[(Away)]

It seems to be okay on nightly. Sure wish I knew why!