1159935 - [Marketplace][Categories] The back button is pointing to the right

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P4)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: Back Arrow Logcat

Description:
When the drawer icon in the top left of the marketplace is selected, the transition to the menu that opens will load in two steps. First a grey overlay will transition over, and then the menu will load over.


Repro Steps:
1) Update a Flame to 20150429010205
2) Open Marketplace app
3) Tap Drawer Icon
4) Tap "Categories"
5) Observe Arrow> Tap arrow> Observe transition

Actual:
The back arrow is pointing to right, when it traditionally points left. Also if the user taps the arrow, the mneu transitions off screen to the left, even though the arrow is pointing to the right


Expected:
The back arrow is pointing left to match the transition of the window


Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150429010205
Gaia: 6e35b0948c42a4398b8a5916015de167121683a1
Gecko: 1ad65cbeb2f4
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0


Repro frequency: 10/10
See attached: Logcat, Video - https://youtu.be/-n_HXgPZ6AI

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This occurs on Flame 2.2, 2.1, and 2.0 due to changes in marketplace being web based

The back arrow is pointing to right, when it traditionally points left. Also if the user taps the arrow, the mneu transitions off screen to the left, even though the arrow is pointing to the right

Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat)(Full Flash)
Build ID: 20150428002500
Gaia: 9f6b1b9082662ba2c14168fc66bb02b4df3141e5
Gecko: e79c19bf19bf
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0


Environmental Variables:
Device: Flame 2.1 (319mb)(Kitkat)(Full Flash)
Build ID: 20150427001201
Gaia: bbe983b4e8bebfec26b3726b79568a22d667223c
Gecko: 82a14be0462c
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Environmental Variables:
Device: Flame 2.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150427000202
Gaia: 84898cadf28b1a1fcd03b726cff658de470282f0
Gecko: f700ee0a507d
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 32.0 (2.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Peter Bylenga [:PBylenga]]

Regardless of screen transitions, our back arrows point to the left across the phone.

NI on UX to confirm.

Comment 3

[David Durst [:ddurst]]

This is per design, but I'm NI design for triaging.

Comment 4

[Stephany Wilkes]

We are not the Marketplace UX team so flagging Liz.

Comment 5

[Philip [:pwalm]]

The transition changed a bit mid-build, so yes, the arrow should be pointing to the left.

Comment 6

[Mark Striemer [:mstriemer]]

Should the arrow be left-aligned now or stay where it is?

Comment 7

[Philip [:pwalm]]

Left align. 20 px from edge of screen.

Comment 8

[Ram Dayal Vaishnav [:ram]]

Can you please put a screenshot of bug and screenshot of what is expected here ? This will be very helpful for the volunteer to fix this.

Comment 9

[Gangineni Ravi Teja]

Hi, 

We need to change the SVG file which will point to left to fix this. 
media/img/nav/back.svg

or
 we can also add rotation of  180 degrees using the css

    -webkit-transform: rotate(180dg);
    -moz-transform: rotate(180deg);
    -ms-transform: rotate(180deg);
    -o-transform: rotate(180deg);
    transform: rotate(180deg);

Let me know which way works better. again if i have to change css *.styl.css is ignored.

Comment 10

[Atique Ahmed Ziad [:atiqueahmedziad]]

Attachment: pull request

Please review the pr :)

Comment 11

[Andy McKay]

Comment on attachment 8608573 [details] [review]
pull request

Looks like chuck is on the PR.

Comment 12

[Mark Striemer [:mstriemer]]

Adding myself as a mentor. Let me know if there's anything I can help with!

Comment 13

[Rigin Oommen]

What about the bug status in the new marketplace beta version?

Comment 14

[Ram Dayal Vaishnav [:ram]]

FTR - Explained Rigin offline that that bug is there on beta version as well.

Comment 15

[Atique Ahmed Ziad [:atiqueahmedziad]]

Attachment: pull request

Thanks you Mark for helping me :)
please review it

Comment 16

[Atique Ahmed Ziad [:atiqueahmedziad]]

https://github.com/mozilla/fireplace/commit/eb5c1df8956963201bc3e0b3711bdc4c7f2dfc9b