Closed Bug 1159978 Opened 4 years ago Closed 4 years ago

Strip out old StartPane activity

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 41
Tracking Status
firefox40 --- affected
firefox41 --- fixed

People

(Reporter: liuche, Assigned: karim, Mentored)

Details

(Whiteboard: [good first bug][lang=java])

Attachments

(4 files, 2 obsolete files)

We switched from a StartPane activity to using a Fragment - this bug is for stripping out the old references to StartPane that are no longer used. (Note, there are some references to forms of "startpane" that are still used, but the activity declaration in AndroidManifest.xml.in is definitely obsolete.)
Whiteboard: [good first bug][lang=js] → [good first bug][lang=java]
Assignee: nobody → benhmida.k
Assignee: benhmida.k → kbenhmida
Attached patch Strip out old StartPane activity (obsolete) — Splinter Review
Attachment #8608272 - Flags: review?(liuche)
Comment on attachment 8608272 [details] [diff] [review]
Strip out old StartPane activity

Review of attachment 8608272 [details] [diff] [review]:
-----------------------------------------------------------------

Just one suggestion and you're good. Upload another version, obsolete the previous patch, and flag me for review :)

::: mobile/android/base/resources/values-large-v11/themes.xml
@@ +7,1 @@
>      

Actually, since there are no more styles in the file, you can just remove it entirely :)

(Also, if you weren't removing the file, you could at least remove these trailing spaces. We don't want to make whitespace-only changes, because that changes the hg history and can be confusing, but if you're already making changes in a place and you see trailing spaces [which are shown in red here] you can just remove them.)
Attachment #8608272 - Flags: review?(liuche) → feedback+
Attachment #8608272 - Attachment is obsolete: true
Attachment #8608286 - Flags: review?(liuche)
Comment on attachment 8608286 [details] [diff] [review]
Strip out old StartPane activity

Review of attachment 8608286 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, I'll land this for you.
Attachment #8608286 - Flags: review?(liuche) → review+
https://hg.mozilla.org/mozilla-central/rev/200691b33953
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Attached file MozReview Request: bz://1159978/karim (obsolete) —
/r/9287 - Bug 1159978 - Strip out old StartPane activity. r=liuche
/r/9289 - Bug 1164301 - Voice input in url activates on click and release. r=liuche
/r/9291 - try: -b o -f -p android-x86,android-api-9,android-api-11 -u all -t none

Pull down these commits:

hg pull -r e3da3cad76c26c8697549e4f2cbf80b2fe1cbca0 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8609631 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.