116002 - [rfe]installer should not clean up download until installation has completed successfully

Status: VERIFIED INVALID

(SeaMonkey :: Installer, enhancement)

Description

[m1scha_m]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:0.9.6+) Gecko/20011218
BuildID:    2001121803

With 200 odd installer bugs this has to be a duplicate, however I downloaded the
nightly for 20 Dec (Australian Eastern Summer Time) only to be faced with the
installer, the first time I had struck it. If this is to be the way of the
future, then before it attempts to install the update it should request that
mozilla, as well as all mozilla windows be closed. If cancel is hit then it is
not easy to recommence setup again. I had to run installer again and go through
the motions of downloading to reinstate it.

Reproducible: Didn't try
Steps to Reproduce:
1.I will know better next time so it should not reoccur
2.
3.

Actual Results:  lost installer and setup and needed to run installer again

Expected Results:  to be told to go offline and exit mozilla and all windows

Comment 1

[Daniel Veditz [:dveditz]]

This isn't a duplicate, this is the result of a recent change which essentially
moved the "is Mozilla running" check from the beginning to the end of the
download stage (from a users point of view). This was changed because we got
constant complaints from folks who wanted to be able to continue browsing during
the long download process.

Curt: after all the files are downloaded we should *NEVER* zap them without
asking if the user cancels. If the installer dies during the download we can
recover and pick up where we left off, we should do the same in this case as
well. We need to tell the user that the files were saved, too. Since it was an
explicit cancel action by the user we could ask before saving, or we could
always save and expand the retry/cancel dialog to state that we will save the
files if cancel is chosen. (In fact, we could consider asking whether the user
wants to save the files even if the install completes OK -- there's an option
during the selection phase, but after spending all that time users may change
their minds.)

I'm nominating this one as a necessary cleanup after removing the startup check.

Comment 2

[m1scha_m]

Personnally I would like the convenience of having an installer or setup program
to install updates, but I would also like to be able to have a copy of the build
which I can use to recover files if something major does go wrong.

Comment 3

[Daniel Veditz [:dveditz]]

I'm not following... if you *know* you want to save the files then click the
option to do so and this entire scenario wouldn't be a problem. This is
happening because when you don't say "save the files" we clean up on exit, and
we're unfortunately interpreting cancelling out when a running Mozilla is found
as a clean exit.

Comment 4

[m1scha_m]

I do not remember the option to save the download appearing. All I got was the
installer having difficulty connecting through my firewall, having to rerun
installer, and having the download commence. From there setup attempted to
install the download.

Comment 5

[m1scha_m]

Would someone tell me what is going on? At around 2230hrs Australian Eastern
Summer time) on Dec 21, from the Mozilla.org page updated on 21 December, I
downloaded a nightly build. When it was installed it had the same build number I
had already downloaded previously, i.e. 2001121803. To my mind that is not
right, so I proceed to the setup folder in Mozilla, where the only executable
file is uninstall.zip, which I find is already unzipped in the unzipped folder
(?why), which, in the absence of a setup application, I ran. I am asked if I
want to delete Mozilla 0.9.7, and when it is finished I find I have now wiped
Mozilla from my machine. Using the installer program I download the files again,
and lo and behold I still have build 2001121803. Has everything stopped in
expectation of issue 0.9.7? Why is there no setup.exe application to manually
setup in case this happens. So what happens now, (puff puff).

Comment 6

[Curt Patrick (gone)]

I'm leaving this bug open but narrowing it down to the one specific thing that I
clearly understand and that I know we should fix.  Thus the change to the
description.  But, I still don't believe we're going to be able to get this into
1.0, so I'm not nominating it.

Owner, if there are still problems with the bits your are getting from the
download site please open another bug with specific.

Comment 7

[Curt Patrick (gone)]

Now I'm pulling a bait and switch (but not intentionally).  I see that I have
already opened a bug (120038) for the problem I just left this bug open for. 
So, I'm closing this bug as invalid because I could not reproduce the other
things the reporter mentioned.  Reporter, if you are still experiencing
problems, reopen this bug, give me new details, and I'll give this attention.

Comment 8

[Grace Bush]

verified

Comment 9

[Brant Gurganus]

[RFE] is deprecated in favor of severity: enhancement.  They have the same meaning.