Closed Bug 1160267 Opened 5 years ago Closed 5 years ago

Build files under |js/src| should not define IMPL_MFBT

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Per glandium, we should not be defining |IMPL_MFBT| in build files under |js/src/*/|. See bug 1145056, comment 42 for more details.

I see three locations to clean up:
> [erahm@mozilla21268 mozilla-central]$ find js/src -name 'moz.build' -exec grep -Hn 'IMPL_MFBT' \{\} \;
> js/src/jsapi-tests/moz.build:105:DEFINES['IMPL_MFBT'] = True
> js/src/shell/moz.build:21:for var in ('EXPORT_JS_API', 'IMPL_MFBT'):
> js/src/gdb/moz.build:25:for var in ('EXPORT_JS_API', 'IMPL_MFBT'):
Attachment #8600102 - Flags: review?(mh+mozilla)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Attachment #8600102 - Flags: review?(mh+mozilla) → review+
(see comment 1)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d2736b5af226
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.