Closed
Bug 1160267
Opened 10 years ago
Closed 10 years ago
Build files under |js/src| should not define IMPL_MFBT
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(1 file)
|
2.26 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Per glandium, we should not be defining |IMPL_MFBT| in build files under |js/src/*/|. See bug 1145056, comment 42 for more details.
I see three locations to clean up:
> [erahm@mozilla21268 mozilla-central]$ find js/src -name 'moz.build' -exec grep -Hn 'IMPL_MFBT' \{\} \;
> js/src/jsapi-tests/moz.build:105:DEFINES['IMPL_MFBT'] = True
> js/src/shell/moz.build:21:for var in ('EXPORT_JS_API', 'IMPL_MFBT'):
> js/src/gdb/moz.build:25:for var in ('EXPORT_JS_API', 'IMPL_MFBT'):
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8600102 -
Flags: review?(mh+mozilla)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
|
||
Updated•10 years ago
|
Attachment #8600102 -
Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•