1160365 - [Navigation] Mobile user settings are in wrong order

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[Philip [:pwalm]]

Attachment: Screen Shot 2015-04-30 at 3.50.27 PM.png

See attached image. The proper order is:

- Settings
- My Apps
- Feedback
- Sign out

Comment 1

[Philip [:pwalm]]

Trivial?!

/( .□.) ︵╰(゜益゜)╯︵ /(.□. /)

Comment 2

[Chuck Harmston [:chuck]]

The priority describes how important it is, the severity describes the impact on the user.

https://wiki.mozilla.org/Marketplace/Bugs#Triage

Comment 3

[Ram Dayal Vaishnav [:ram]]

Attachment: marketplace_bug_menu_order.png

Even desktop user's settings are also in same order (Attaching screenshot). Should their order also change ?

Comment 4

[Philip [:pwalm]]

Yes, correct. I thought the desktop had changed to the correct order previously, but I guess not!

Comment 5

[simplyblue24]

Attachment: Fixed the navigation bar order

Pull request for the bug:https://github.com/mozilla/fireplace/pull/1225

Comment 6

[simplyblue24]

I have taken this bug :). Please find the pull request in the above comment.

Comment 7

[David Durst [:ddurst]]

(In reply to Manoj from comment #6)
> I have taken this bug :). Please find the pull request in the above comment.

Manoj -- that pull request has been closed. Can you update the pull request or create a new one in keeping with the last comment?

Comment 8

[Atique Ahmed Ziad [:atiqueahmedziad]]

Please create each pull request for each bug. As the previous pull request is closed please create a new pull request. Thanks

Comment 9

[Nadif Ali Fahim]

Attachment: patch

The Pull request has been sent! The Bug has been patched!

Comment 10

[Atique Ahmed Ziad [:atiqueahmedziad]]

(In reply to Nadif Ali Fahim from comment #9)
> Created attachment 8623653 [details] [review]
> patch
> 
> The Pull request has been sent! The Bug has been patched!

Commented on the pull request

Comment 11

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/fireplace/commit/0ef680ad5af744b171541d6f09c9fa648fd9c150

Thanks for the patch, Nadif!

Clearing the ni? since this is fixed.

Comment 12

[Atique Ahmed Ziad [:atiqueahmedziad]]

Comment on attachment 8623653 [details] [review]
patch

Thanks for working on it. Congrats on your first bug fixed for Mozilla & Firefox Marketplace.