Closed Bug 1160490 Opened 9 years ago Closed 9 years ago

Windows 8 x64 spidermonkey shell build uses i686-pc-mingw32.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox39 --- fixed
firefox40 --- fixed
firefox-esr38 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Derived from bug 1160137.

http://ftp.mozilla.org/pub/mozilla.org/spidermonkey/try-builds/arai_a@mac.com-5021b3857357/try-win64/try_win64_spidermonkey-compacting-bm79-try1-build2.txt.gz
> checking host system type... i686-pc-mingw32
> checking target system type... i686-pc-mingw32
> checking build system type... i686-pc-mingw32

that seems to be the reason why we get "error C2118: negative subscript" in opt build.
we should pass --target=x86_64-pc-mingw32 and --host=x86_64-pc-mingw32 from autospider.sh.
Try is running: https://treeherder.mozilla.org/#/jobs?repo=try&revision=95e8d0c02f82&exclusion_profile=false
at least it passes plain builds both with opt and debug.
Blocks: 1150618
Just added "--target=x86_64-pc-mingw32 --host=x86_64-pc-mingw32" to configure args for msys with win64.

Green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=95e8d0c02f82&exclusion_profile=false

This also needs the patch for bug 1160137 to make it work with debug build (win64-debug)
Assignee: nobody → arai.unmht
Attachment #8600317 - Flags: review?(sphink)
Comment on attachment 8600317 [details] [diff] [review]
Set target to x86_64 for spidermonkey shell build on Windows 8 x64.

Review of attachment 8600317 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good to me. Thanks! (I never did look closely at the win64 builds to see if they were doing something sensible.)
Attachment #8600317 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/8e40c9f2da34
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.