1160615 - add a link for graphs on the summary (right now it is just a link to 'details' - the subtest compare view)

Status: RESOLVED DUPLICATE of bug 1220680

(Tree Management :: Perfherder, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

perfherder does a great job of showing the comparison for a summary series, but there is no easy way to get a graph, we can copy the code from the subtestctrl and have a link for graphs.

Comment 1

[William Lachance (:wlach)]

Yes, this would be good to have!

Comment 2

[Jonathan French (:jfrench)]

Casual discussion w/wlach and jmaher on IRC, I will have a look at this one, so removing the ateam-soc tag.

Comment 3

[Jonathan French (:jfrench)]

I've made the tweak, now to go build a new vagrant with our new merged repo and prove it's working :)

Comment 4

[Jonathan French (:jfrench)]

Attachment: treeherder-PR549

Please see above PR for status and review.

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8608986 [details] [review]
treeherder-PR549

I like the approach/change here but as stated in the PR I'd like to investigate the possibility of consolidating code. Feel free to re-r? me after looking into that.

Comment 6

[Jonathan French (:jfrench)]

I was chatting with @wlach on IRC, and he mentioned the need for this addition is now uncertain. So we'll hold off on this PR pending further usability review of Compare in the coming weeks.

Comment 7

[Jonathan French (:jfrench)]

After checking with Will we agreed to close the PR for now unmerged. I'll also unassign myself in case someone else wants to pick it up and/or we determine how we want to link from compare>graphs later.

Comment 8

[William Lachance (:wlach)]

I wound up implementing something pretty similar to this (with some extra logic to make sure that things worked, even when the comparison was old) in bug 1220680.