Closed Bug 1160678 Opened 5 years ago Closed 5 years ago

Pocket door hangers arent automatically closed

Categories

(Firefox :: Pocket, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 40
Tracking Status
firefox38.0.5 --- verified
firefox39 --- verified
firefox40 --- verified

People

(Reporter: pdehaan, Assigned: jaws)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

(originally filed as https://github.com/Pocket/Firefox/issues/14)

### Steps to reproduce:
1. Sign in to pocket dev w/ verified FxA account
2. Click the Pocket button in the toolbar to add a link to your reading list.
3. Click the Pocket button in the toolbar AGAIN and click the "Remove Page" link.


### Actual results:
The door hanger says "Page Removed" with a Pocket logo, but the door hanger never auto-closes.
(see https://cloud.githubusercontent.com/assets/557895/7438443/395f1a4e-f019-11e4-9cf2-6d1515127a90.png)


### Expected results:
The door hanger should auto close after 4-6 seconds (and ideally be a lot shorter since it only says "Page Removed").


### Workaround:
Click outside of the door hanger to dismiss it.
In diff'n the code from the patches and the add-on in the repo, it appears that the auto-hide code was commented out:
https://github.com/Pocket/Firefox/compare/develop...compare/patch-update-1?expand=1#diff-73b7fce17bd3a7cb741602a692692902L109

Jared can we get this back in? Was there an issue with the code that we can work on resolving?
Attached patch PatchSplinter Review
We can uncomment the code now. As part of bug 1159744 I had to change how getPanel() worked (the panel is a temporary panel when the button exists in the toolbar).

We can now use getPanel() cleanly, and as such this code path now works.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8601681 - Flags: review?(dolske)
Attachment #8601681 - Flags: review?(dolske) → review+
https://hg.mozilla.org/mozilla-central/rev/799f4c06bbc8
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Comment on attachment 8601681 [details] [diff] [review]
Patch

a+ for uplift in service of 38.0.5 spring launch campaign.
Attachment #8601681 - Flags: approval-mozilla-beta+
Attachment #8601681 - Flags: approval-mozilla-aurora+
Comment on attachment 8601681 [details] [diff] [review]
Patch

[Triage Comment]
Fix the branch
Attachment #8601681 - Flags: approval-mozilla-beta+ → approval-mozilla-release+
Flags: qe-verify+
QA Contact: andrei.vaida
Confirmed fixed on Nightly 40.0a1 (2015-05-07), using Ubuntu 14.04 (x64), Windows 7 (x64) and Mac OS X 10.9.5, with Bug 1162033 encountered and being treated separately.
Blocks: Pocket
Status: RESOLVED → VERIFIED
Depends on: 1162033
OS: Unspecified → All
Hardware: Unspecified → All
Verified as fixed using Firefox 38.0.5 beta 1 build 2 under Ubuntu 14.04 LTS 32-bit, Windows 7 64-bit and Mac OS X 10.9.5.
Verified fixed on Firefox 39 Beta 1 (20150523155636) under Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5. The confirmation/warning doorhangers are automatically closed after about 5 seconds.
You need to log in before you can comment on or make changes to this bug.