1160992 - Data connection can be toggled when there is no sim card

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[zouyi(Leave from Mozilla)]

Attachment: logcat002.txt

[1.Description]:
[Flame v2.2&3.0][Nexus5 2.2&3.0]The data traffic option in Notification is not available, when the cell phone service goes out.
Found time:15:47
See attachment:logcat002.txt,VIDEO1416.mp4

[2.Testing Steps]: 
prerequisite:Insert an arrearaged card into the device
1.Pull down the Notification.
2.Tap the data traffic button.

[3.Expected Result]: 
2.The data traffic button will be opened.

[4.Actual Result]: 
2.The data traffic button is not available and can't open the data traffic in notification panel, but can open it in settings.

[5.Reproduction build]: 
N5 v2.2 build(Affected):
Build ID               20150503002500
Gaia Revision          8d14361337e608c8cdf165ea5034db5eda23b618
Gaia Date              2015-05-01 18:23:46
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/cb7cb6597c91
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150503.040229
Firmware Date          Sun May  3 04:02:46 EDT 2015
Bootloader             HHZ12f

Nexus_5 3.0(Affected):
Build ID               20150503160200
Gaia Revision          e18cce173840d6ff07fb6f1f0e0ffb58b99aab3e
Gaia Date              2015-05-02 04:27:01
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/dc5f85980a82
Gecko Version          40.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150503.193953
Firmware Date          Sun May  3 19:40:11 EDT 2015
Bootloader             HHZ12f

Flame 2.2(Affected):
Build ID               20150503002500
Gaia Revision          8d14361337e608c8cdf165ea5034db5eda23b618
Gaia Date              2015-05-01 18:23:46
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/cb7cb6597c91
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150503.040203
Firmware Date          Sun May  3 04:02:15 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0(Affected):
Build ID               20150503160200
Gaia Revision          e18cce173840d6ff07fb6f1f0e0ffb58b99aab3e
Gaia Date              2015-05-02 04:27:01
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/dc5f85980a82
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150503.193941
Firmware Date          Sun May  3 19:39:52 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

[8.Note]:
We can open the data traffic in settings.

Comment 1

[zouyi(Leave from Mozilla)]

Attachment: VIDEO1416.mp4

Comment 2

[Eric Chang [:ericcc] [:echang]]

Hi zuoyi, Could you try again with ril log debug flag on(reboot needed) thanks.
So the log will have something like RILContentHelp... etc
Thank you.

ps. case for prepaid SIM without credit

Comment 3

[zouyi(Leave from Mozilla)]

Attachment: logcat003.txt

Update logcat with ril log.

N5_2.2 :
Build ID               20150504002502
Gaia Revision          8d14361337e608c8cdf165ea5034db5eda23b618
Gaia Date              2015-05-01 18:23:46
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/cb7cb6597c91
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150504.041256
Firmware Date          Mon May  4 04:13:14 EDT 2015
Bootloader             HHZ12f

Comment 4

[zouyi(Leave from Mozilla)]

Attachment: logcat004.txt

Comment 5

[Eric Chang [:ericcc] [:echang]]

Hi Howie, Anyone who can help to check this, thank you.

Comment 6

[howie [:howie]]

Hi Arthur, it seems more likely an utility tray bug, but can you confirm? If so, please help to change to the right component, thanks.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

From the log the settings database seems corrupted. I suspect that other settings also malfunction.

Is there any steps before the symptom being observed? Can a full flash fix the problem?

Comment 8

[zouyi(Leave from Mozilla)]

Hi Arthur, there is no other special steps. But please note that the telephone charge should be overdue as I mentioned in comment 0.

Comment 9

[zouyi(Leave from Mozilla)]

Hi arthur,
This bug was found after full flashing device.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

There is no obvious error in RIL logs but I keep seeing settings db errors. Could you try if other settings such as Geolocation works (by toggling it and restart the settings app to see if the change is kept)?

Comment 11

[zouyi(Leave from Mozilla)]

(In reply to Arthur Chen [:arthurcc] from comment #10)
> There is no obvious error in RIL logs but I keep seeing settings db errors.
> Could you try if other settings such as Geolocation works (by toggling it
> and restart the settings app to see if the change is kept)?

Hi arthur, other function works normally.

Comment 12

[Eric Chang [:ericcc] [:echang]]

I cannot reproduce that with sim cards from Taiwanese telecom. Still need Arther and Zouyi's help. 
Hi, Zouyi, What if you try this case right after flashing or resetting? If it is still reproducible, we can rule out the possibility of doing lots of testing and corrupting the db. Does it make sense?

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

I could not reproduce this either. BTW, if other functions work normally I think the settings db is not corrupted.

Comment 14

[zouyi(Leave from Mozilla)]

Hi Eric, 
We found that we can enable data traffic from Settings app with no SIM inserted,  but it can't be enabled from notifications.Besides, we can always reproduce this issue with a SIM card whose charge is overdue.

Comment 15

[Eric Chang [:ericcc] [:echang]]

Without SIM card, the menu items should be disable (as in 2.1).
Hi Arthur, we will open a new bug to address that.
Hi Zouyi, Could you create one for the no sim scenario, thank you.


(In reply to zouyi from comment #14)
> Hi Eric, 
> We found that we can enable data traffic from Settings app with no SIM
> inserted,  but it can't be enabled from notifications.Besides, we can always
> reproduce this issue with a SIM card whose charge is overdue.

Comment 16

[zouyi(Leave from Mozilla)]

Hi Eric,
Please refer to bug 1165220.

Comment 17

[Arthur Chen [:arthurcc][inactive after 6/30]]

After checking the code in quick settings[1], I think we should do the same checking in settings app in order to keep the behavior consistent. By doing this we can solve bug 1165220 at once.

[1]: https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/quick_settings.js#L526

Comment 18

[Eric Chang [:ericcc] [:echang]]

[Blocking Requested - why for this release]: Make user interface more consistent and reasonable.

Comment 19

[Arthur Chen [:arthurcc][inactive after 6/30]]

Jenny, should we allow users toggle data connection when there is no available or valid sim card? System app now disables the toggle in this case but settings app doesn't. 

Note that both data connection and data roaming settings are not corresponding to sim card but the device.

Comment 20

[Jenny Lee]

Hi Arthur,

Per discussion, data connection should be disabled when there is no available or valid sim card. Thanks!

Hi Francis,

(Not directly related to this bug but I'd like to take the chance to get your opinion on an issue :-) 
Right now when there is no available or valid SIM card, mobile data toggle button in notification tray will not be tappable but looks tappable. Since user can still turn on data connection in Settings, data connection would appear to be ON in notification tray but user won't be able to turn it off. 

After discussion with Arthur, we will make the change to disable data connection toggle in Settings to avoid such issue. With that being said, do you think it is necessary to disable mobile data toggle button in notification tray when there is no available or valid sim card?

Comment 21

[Jenny Lee]

Attachment: [Settings] APN Settings v1.41.pdf

Spec updated based on comment 20 (minor change on p.5).

Comment 22

[GitHub Autolander Bot]

Attachment: [gaia] evanxd:bug-1160992 > mozilla-b2g:master

Comment 23

[Evan Tseng [:evanxd]]

Added patch[1].

[1]: https://github.com/evanxd/gaia/commit/e894ec7ae88408ca9d7246e58e7c97046ba1cac7

Comment 24

[Evan Tseng [:evanxd]]

Comment on attachment 8649190 [details] [review]
[gaia] evanxd:bug-1160992 > mozilla-b2g:master

Hi Fred,

Could you review the patch?

Thanks.

Comment 25

[[e-mail]]

Comment on attachment 8649190 [details] [review]
[gaia] evanxd:bug-1160992 > mozilla-b2g:master

I have pretty limit knowledge about APN, add evelyn to bring more eyes to check the change.

Comment 26

[[e-mail]]

Comment on attachment 8649190 [details] [review]
[gaia] evanxd:bug-1160992 > mozilla-b2g:master

Thanks for providing the patch. Please address my comments in github and add a unit test.

Comment 27

[Evan Tseng [:evanxd]]

Fred, thanks for the review. I've updated the patch[1] for the comments. And I'll add test later.

[1]: https://github.com/evanxd/gaia/commit/10f4b649c20def617ce09674eee3192cbe0a9c2f

Comment 28

[Evan Tseng [:evanxd]]

Comment on attachment 8649190 [details] [review]
[gaia] evanxd:bug-1160992 > mozilla-b2g:master

Fred, could you review the patch?

And we should add unit tests for it after we refactor `carrier.js`[1].

[1]: https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/carrier.js

Comment 29

[[e-mail]]

Comment on attachment 8649190 [details] [review]
[gaia] evanxd:bug-1160992 > mozilla-b2g:master

lgtm, 

we should refactor the panel so we can add test coverage for these functions...

Comment 30

[Evelyn Hung]

Comment on attachment 8649190 [details] [review]
[gaia] evanxd:bug-1160992 > mozilla-b2g:master

Hi Evan, thanks for the patch. However, according to the spec in comment 21 said:
Data connection toggle will be disabled when there’s no available or valid SIM
card. Data roaming is only available when data connection is on.

I feel if data connection is disabled which means it's off (no matter what the user set before), we should:
1) let the toggle looks like off and disable the toggle;
2) disable data roaming toggle as well.

Comment 31

[Evelyn Hung]

BTW, the bug title doesn't match things you done in the patch. Could you update the title?

Comment 32

[Evan Tseng [:evanxd]]

Update the patch: https://github.com/evanxd/gaia/commit/e5dcae361f67185ea1f386ffa017e18742b8d849

Comment 33

[Evan Tseng [:evanxd]]

Comment on attachment 8649190 [details] [review]
[gaia] evanxd:bug-1160992 > mozilla-b2g:master

Evelyn,

Could you review this?

Thanks.

Comment 34

[Evelyn Hung]

Comment on attachment 8649190 [details] [review]
[gaia] evanxd:bug-1160992 > mozilla-b2g:master

redirect to :jaoo since he wrote this part before. :)

Comment 35

[Evelyn Hung]

(In reply to Evelyn Hung [:evelyn] from comment #34)
> Comment on attachment 8649190 [details] [review]
> [gaia] evanxd:bug-1160992 > mozilla-b2g:master
> 
> redirect to :jaoo since he wrote this part before. :)

This patch addressed my comment 30 so it looks good to me now. However, it's better to have author's second review.

Comment 36

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8649190 [details] [review]
[gaia] evanxd:bug-1160992 > mozilla-b2g:master

LGTM, r=me.

Tested on a device. Seems to works fine and nothing gets broken. Land at will please. Thanks for taking care of it.

Comment 37

[Evan Tseng [:evanxd]]

If the CI[1] is good, let's land the code.

[1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=eb64215108ca533c79b61b6fa9c9530a25053165

Comment 38

[Evan Tseng [:evanxd]]

CI: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=d2f630909fcb0b76a7ba86c3bb987ed23a1d249d

Comment 39

[Evan Tseng [:evanxd]]

Don't know why the GijTV is failed. And I don't think that is due to this patch.

Comment 40

[Evan Tseng [:evanxd]]

treeherder: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=8c3a5e4deef12af99e4c46d447d09e5401b50e90

If it is good, let's land the code.

Comment 41

[Evan Tseng [:evanxd]]

master: https://github.com/mozilla-b2g/gaia/commit/79dba9c072f6aaec932be4eabd4f006f07bacb24

Comment 42

[Shally Li（leave from Mozilla）]

Hi Evan,

    According to comment 14 & comment 15, this current bug is that data connection should be disabled when there is no available or valid sim card. And another Bug 1165220 (no SIM card in device) is your fixed bug as mentioned in comment 31 & comment 32.


    By the STR in comment 0 & comment 14, I have verified the problem (Data connection can be toggled when there is no sim card), it has fixed on latest Flame KK v2.5, but not fixed on latest Aries KK v2.5.

Actual results: 
(Pass)On FlameKK v2.5: Data connection in settings can't be toggled when there is no sim card.
(Fail)On AriesKK v2.5: Data connection in settings can be switched to 'on' when there is no sim card, but actually the Data connection is shown as 'off' on the utility tray.

See attachments: Pass_FlameKK_v2.5(no SIM).3gp, Fail_AriesKK_v2.5(no SIM).3gp and logcat1624_Aries2.5(no SIM).txt
Reproduce rate: 0/10 (Flame), 5/5(Aries)


Device: Flame KK 2.5 (Pass)
Build ID               20150831150202
Gaia Revision          c80e8ff25425b007181fd6e3de0500a0358fab37
Gaia Date              2015-08-31 16:35:09
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cafb1c90f794a73100a8f0afb9fe3301df0f2bde
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150831.183117
Firmware Date          Mon Aug 31 18:31:30 EDT 2015
Bootloader             L1TC000118D0
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Fail)
Build ID               20150831201354
Gaia Revision          c80e8ff25425b007181fd6e3de0500a0358fab37
Gaia Date              2015-08-31 16:35:09
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cafb1c90f794a73100a8f0afb9fe3301df0f2bde
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150831.193718
Firmware Date          Mon Aug 31 19:37:26 UTC 2015
Bootloader             s1

Comment 43

[Shally Li（leave from Mozilla）]

Attachment: Pass_FlameKK_v2.5(no SIM).3gp

Comment 44

[Shally Li（leave from Mozilla）]

Attachment: logcat1624_Aries2.5(no SIM).txt

Comment 45

[Shally Li（leave from Mozilla）]

Attachment: Fail_AriesKK_v2.5(no SIM).3gp