116108 - [viewpoint] Windowless plugin does not preserve its position if in a table cell

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P2)

Description

[av (gone)]

This bug is off-spring from bug 114667.

If you use <table><tr><td><embed ...><\td><\tr><\table> construction with the 
windowless plugin, you will see that the plugin is not drawn in the table. With 
the fix from bug 116093 it is drawn correctly but if the table position changes 
the plugin does not follow. Test case to follow, please install ViewPoint plugin 
for testing purposes: 
http://cole.viewpoint.com/~aberger/viewpointplugin.zip -- run .exe from this 
package, it will install the engine, then copy the plugin dll into the Plugins 
folder and xpt file in the Components folder. You may use newer than in the 
package dll and xpt:
http://cole.viewpoint.com/~aberger/npViewpoint.zip
http://cole.viewpoint.com/~aberger/npViewpoint.xpt

Comment 1

[av (gone)]

...restoring original nominations.

Comment 2

[av (gone)]

Attachment: test case which uses <table><tr><td><embed ...><\td><\tr><\table> construction

Run this test case and resize the window to see the problem. The table is
<center>'ed and moves, the plugin does not.

Comment 3

[av (gone)]

Attachment: patch v.1

This patch assumes that the patch v.2 from bug 116093 is already applied. With
both patches all test cases now work fine. Issue with dirty rectangle is still
to be addressed.

Please review and try.

Comment 4

[David Brittain]

This patch works for me and it also fixes 110094.

Comment 5

[David Brittain]

One problem with the patch is that in the case where DidReflow is called 
correctly then all the stuff to recalculate the origin is done twice which is a 
bit of a waste. Is it worth putting a note in the code that a better way should 
be found of fixing this in the future? Ie. figuring out why DidReflow isn't 
being called when the plugin is in a table.

Comment 6

[av (gone)]

Twice, you mean in DidReflow and Paint?

Tables are not reflown by design, unless the size is changed. This was 
a performance consideration, I beleive.

Comment 7

[av (gone)]

Attachment: patch v.2

This patch is just to reflect changes in bug 116093, so this patch will work
with patch v.4 from bug 116093.

Comment 8

[Peter Lubczynski]

Comment on attachment 62422 [details] [diff] [review]
patch v.2

r=peterl

Comment 9

[David Brittain]

Andrei, I did mean in Paint and DidRfelow. Your patch in bug 116093 that moves
everything into the Paint method seems a good solution and avoids this happening.

Comment 10

[Marc Attinasi]

Comment on attachment 62422 [details] [diff] [review]
patch v.2

sr=attinasi

Comment 11

[av (gone)]

In the trunk. Nominating for 0.9.7.

Comment 12

[av (gone)]

In 0.9.4, marking fixed.

Comment 13

[shrirang khanzode]

Confirmed fixed on mozilla trunk 122603(viewpoint plugin stays inside table and 
does not move out).
 Ari, could you please confirm the fix as well. Thanks! 

I have filed  http://bugscape.mcom.com/show_bug.cgi?id=11566 for a problem that 
I see using commercial trunk builds. Cannot verify the fix on 
the embedding branch unless I get thru that problem.

Comment 14

[shrirang khanzode]

testcase works, plugin draws inside table when loaded. used build 0101 0.9.4 
branch. VERIF.

Comment 15

[shrirang khanzode]

Just noticed what Ari mentioned in one of his email('I have also seen a problem 
with our content drawing incorrectly when you scroll the page.  Again, I don't 
know where the problem lies')

When I resized the test page and tried to scroll...there was a problem rendering 
the content in the plugin and scrollbar got locked. Ari, pls file a bug if you 
think this is a mozilla problem.Thanks!

Comment 16

[Ari Berger]

I have been working on another (higher priority) bug.  I will look into this in 
the next few days.
What is the preference? Would you rather I log the issue when it may well be 
our bug, or wait until I am reasonably sure it is Mozilla's?
Thanks.

Comment 17

[shrirang khanzode]

Ari, I filed bug 117793 for the issue that you mentioned and what I saw here. 
Pls add your comments to it whenever you get time. Thanks!

Comment 18

[shrirang khanzode]

adding keyword 'verified0.9.4'