1161092 - A theme generated by the ThemeEditor can not be selected in the settings app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Theme Editor, defect, P1)

Description

[Etienne Segonzac (:etienne)]

Initially when you install the theme it works, but if you go back to the Default theme from the settings app, then try to go back to a Studio theme it won't work.

It's because the themes we generate don't have a wallpaper.json.

We should add an empty wallpaper.json to the generated zips (js/generation.js) and also use it to store the picture in the case of an Autotheme.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

[Blocking Requested - why for this release]:

Comment 2

[Hubert Figuiere [:hub]]

An empty wallpaper.json will not work either. It needs a bit more tweaking. Several solution:

1. change the settings app to allow NOT having a valid wallpaper - this my open up a huge can of worm.
2. force a default wallpaper to be added to themes. Something like the default theme wallpaper.

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

spark+ as we need this for the Studio.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

UX to review whether we want this in the spark dogfooding build or not.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Oops.  wrong bug.  We do need this in the spark build.  sorry for the noise.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] hfiguiere:bug1161092-theme-wallpaper > mozilla-b2g:master

Comment 7

[Hubert Figuiere [:hub]]

The current PR make the test fail. And the test fail because of bug 1169363, and possibly the PR itself.

Comment 8

[Hubert Figuiere [:hub]]

We'll need a studio patch as wall to create the empty wallpaper.json.

Comment 9

[Hubert Figuiere [:hub]]

Attachment: Link to Github pull-request: https://github.com/fxos/studio/pull/14

This is the part in studio to generate a wallpaper.json

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 8613043 [details] [review]
Link to Github pull-request: https://github.com/fxos/studio/pull/14

lgtm :)

Comment 11

[Hubert Figuiere [:hub]]

Studio patch landed:
https://github.com/fxos/studio/commit/0faa606f92f90011d4890bf97ff61bbe5e1741cd

Comment 12

[Hubert Figuiere [:hub]]

Comment on attachment 8611407 [details] [review]
[gaia] hfiguiere:bug1161092-theme-wallpaper > mozilla-b2g:master

Arthur,

We need this change to settings to be able to have a theme installed without wallpaper.

Let me know if you have any concerns.

Thanks,

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8611407 [details] [review]
[gaia] hfiguiere:bug1161092-theme-wallpaper > mozilla-b2g:master

r=me, thanks!

Comment 14

[Hubert Figuiere [:hub]]

Merged
https://github.com/mozilla-b2g/gaia/commit/9e10483c5808f94f4a0a9f6afe30aae2c5b42b4c