Closed Bug 1161092 Opened 5 years ago Closed 4 years ago

A theme generated by the ThemeEditor can not be selected in the settings app

Categories

(Firefox OS Graveyard :: Gaia::Theme Editor, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:2.5+, b2g-master fixed)

RESOLVED FIXED
2.2 S14 (12june)
blocking-b2g 2.5+
Tracking Status
b2g-master --- fixed

People

(Reporter: etienne, Assigned: hub)

References

Details

(Whiteboard: [spark])

Attachments

(2 files)

Initially when you install the theme it works, but if you go back to the Default theme from the settings app, then try to go back to a Studio theme it won't work.

It's because the themes we generate don't have a wallpaper.json.

We should add an empty wallpaper.json to the generated zips (js/generation.js) and also use it to store the picture in the case of an Autotheme.
Priority: -- → P1
Assignee: nobody → hub
Status: NEW → ASSIGNED
[Blocking Requested - why for this release]:
blocking-b2g: --- → spark?
Whiteboard: [spark]
An empty wallpaper.json will not work either. It needs a bit more tweaking. Several solution:

1. change the settings app to allow NOT having a valid wallpaper - this my open up a huge can of worm.
2. force a default wallpaper to be added to themes. Something like the default theme wallpaper.
spark+ as we need this for the Studio.
blocking-b2g: spark? → spark+
UX to review whether we want this in the spark dogfooding build or not.
blocking-b2g: spark+ → spark?
Flags: needinfo?(firefoxos-ux-bugzilla)
Oops.  wrong bug.  We do need this in the spark build.  sorry for the noise.
blocking-b2g: spark? → spark+
Flags: needinfo?(firefoxos-ux-bugzilla)
Depends on: 1169363
The current PR make the test fail. And the test fail because of bug 1169363, and possibly the PR itself.
We'll need a studio patch as wall to create the empty wallpaper.json.
This is the part in studio to generate a wallpaper.json
Attachment #8613043 - Flags: review?(etienne)
Comment on attachment 8613043 [details] [review]
Link to Github pull-request: https://github.com/fxos/studio/pull/14

lgtm :)
Attachment #8613043 - Flags: review?(etienne) → review+
Comment on attachment 8611407 [details] [review]
[gaia] hfiguiere:bug1161092-theme-wallpaper > mozilla-b2g:master

Arthur,

We need this change to settings to be able to have a theme installed without wallpaper.

Let me know if you have any concerns.

Thanks,
Attachment #8611407 - Flags: review?(arthur.chen)
Comment on attachment 8611407 [details] [review]
[gaia] hfiguiere:bug1161092-theme-wallpaper > mozilla-b2g:master

r=me, thanks!
Attachment #8611407 - Flags: review?(arthur.chen) → review+
Merged
https://github.com/mozilla-b2g/gaia/commit/9e10483c5808f94f4a0a9f6afe30aae2c5b42b4c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
blocking-b2g: spark+ → 2.5+
Target Milestone: --- → 2.2 S14 (12june)
You need to log in before you can comment on or make changes to this bug.