1161095 - Installing/updating a theme more than once should not duplicate the theme in the Settings app themes list

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Theme Editor, defect, P1)

Description

[Etienne Segonzac (:etienne)]

In js/generation.js, when the |mozApps.mgmt.import| call succeeds, we should store the manifestURL in the Studio IDB database.

This way when enabling/updating a theme that already has a manifestURL set we can uninstall it first and prevent the duplication.

Comment 1

[Etienne Segonzac (:etienne)]

Hope to get this one done this week to unblock the rest.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] etiennesegonzac:bug-1161095 > mozilla-b2g:master

Comment 3

[Etienne Segonzac (:etienne)]

Attachment: Studio part

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 8604081 [details] [review]
[gaia] etiennesegonzac:bug-1161095 > mozilla-b2g:master

I don't think we can use mozApps.mgmt.import() to push an update so I'm deinstalling/reinstalling the theme.

If we keep the prompt it's really confusing (the user gets prompted to "delete" just after tapping an "install" button).

What do you think?

Comment 5

[[:fabrice] Fabrice Desré]

(In reply to Etienne Segonzac (:etienne) from comment #4)
> Comment on attachment 8604081 [details] [review]
> [gaia] etiennesegonzac:bug-1161095 > mozilla-b2g:master
> 
> I don't think we can use mozApps.mgmt.import() to push an update so I'm
> deinstalling/reinstalling the theme.
> 
> If we keep the prompt it's really confusing (the user gets prompted to
> "delete" just after tapping an "install" button).
> 
> What do you think?

Yep, that's not a great experience. The fix looks ok but I'm slightly worried about generalizing that too much (I guess updating add-ons will need the same change).

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 8604081 [details] [review]
[gaia] etiennesegonzac:bug-1161095 > mozilla-b2g:master

Moving to review then!
Added some tests (this part was not covered by unit tests yet, just homescreen integration tests).

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 8604082 [details] [review]
Studio part

Mind taking a look? :)

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8604081 [details] [review]
[gaia] etiennesegonzac:bug-1161095 > mozilla-b2g:master

Nice find. LGTM.

Comment 9

[Hubert Figuiere [:hub]]

Comment on attachment 8604082 [details] [review]
Studio part

Looks good

Comment 10

[Etienne Segonzac (:etienne)]

Studio part landed: https://github.com/fxos/studio/commit/7e3b65ad5ac9819315adf5a5e260dd20d3142a9f

Comment 11

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/f75abf8b9bd8ad567f987ca0511e9b692f7ec986