1161103 - On the Detail panel, the "Install this theme" and "Fork this theme" list elements should be replaced by buttons at the top of the panel

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Theme Editor, defect)

Description

[Etienne Segonzac (:etienne)]

See IxD spec: https://mozilla.app.box.com/s/qhofrys1g7p4qzjki07eayjhq7qj9wcc

Comment 1

[Etienne Segonzac (:etienne)]

The state of the "Enable" button will be based on the presence of the `manifestURL` on the theme object.
(if it's present the theme is already enabled)

Comment 2

[Hubert Figuiere [:hub]]

Do we have a visual design for the icons?

Comment 3

[Etienne Segonzac (:etienne)]

(In reply to Hubert Figuiere [:hub] from comment #2)
> Do we have a visual design for the icons?

https://mozilla.app.box.com/s/2rfhpr44jj4hoaulpsmu5tn6z31t7wsf

https://mozilla.app.box.com/s/02gm66evje9wwlmwc13phxuq87x90tsr

(the meta bug User Story has a bunch of links)

Comment 4

[Hubert Figuiere [:hub]]

Attachment: Link to Github pull-request: https://github.com/fxos/studio/pull/11

Current proposal. I'm sure I'm using the gaia-button wrong, notably changing min-width.

Comment 5

[Hubert Figuiere [:hub]]

Comment on attachment 8605351 [details] [review]
Link to Github pull-request: https://github.com/fxos/studio/pull/11

I think I got the alignment now.

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 8605351 [details] [review]
Link to Github pull-request: https://github.com/fxos/studio/pull/11

Made quite a few comments so I'll need to take another look at the patch.
But it's *really* cool to see the app shape up like this :)

Comment 7

[Hubert Figuiere [:hub]]

Comment on attachment 8605351 [details] [review]
Link to Github pull-request: https://github.com/fxos/studio/pull/11

I did the changes suggested. Also I had to update gaia-button in the repo as it fixed bugs with disable and a few other, including layout that I had to rework a little bit. Beside the component update I believe the patch is now smaller.

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 8605351 [details] [review]
Link to Github pull-request: https://github.com/fxos/studio/pull/11

r=me with the following changes:
* the superfluous css block removed (or explained :))
* keeping the button disabled after the install (bug 1161098 is coming soon)
* squashing/rebasing the PR

Thanks!

Comment 9

[Hubert Figuiere [:hub]]

Addressed the comments.
Merged
https://github.com/fxos/studio/commit/9ed514996f34eb137e04d87b97cabcb169490f15