Closed
Bug 1161099
Opened 10 years ago
Closed 10 years ago
"Fork this theme" should use a gaia-dialog too instead of a prompt
Categories
(Firefox OS Graveyard :: Gaia::Theme Editor, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: etienne, Assigned: hub, Mentored)
References
Details
(Whiteboard: [lang=js])
Attachments
(1 file)
We already use the gaia-dialog component when creating a new theme.
For consistency we should remove the |prompt| call and replace it by a dialog.
|
Reporter | |
Updated•10 years ago
|
Mentor: etienne
Whiteboard: [lang=js]
|
|
Reporter | |
Updated•10 years ago
|
Blocks: spark-theme-editor
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → hub
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•10 years ago
|
||
This is currently based off bug 1161104
Attachment #8604116 -
Flags: review?(etienne)
|
|
Reporter | |
Comment 2•10 years ago
|
||
Comment on attachment 8604116 [details] [review]
Link to Github pull-request: https://github.com/fxos/studio/pull/10
r=me with the input cleanup on close
Optional: since none of the dialogs are actually part of the |Main|'s panel we should probably extract all of those to a |Dialog| singleton, but this can be a follow up patch.
Attachment #8604116 -
Flags: review?(etienne) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Addressed nit.
Merged
https://github.com/fxos/studio/commit/b458bf3a5fabe5a5ae18176720845e35ab85f445
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•