1161456 - [RTL][First Time Experience]The ellipsis of long LTR Wi-Fi name is located at wrong side of name in FTE.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P2)

Description

[Sue]

Attachment: ellipsis of long wifi name in FTE.png

[1.Description]:
[RTL][Flame v2.2 & v3.0][Nexus 5 2.2 & 3.0][First Time Experience]The ellipsis of long LTR Wi-Fi name is located at left side of name in "Select a network" view in FTE.
See attachment:ellipsis of long wifi name in FTE.png

[2.Testing Steps]: 
1. Flash a device or launch FTE.
2. Tap "Next" button until reaching "Select a network" view.
3. Observe the Wi-Fi with long LTR name in list.

[3.Expected Result]: 
3. The ellipsis should be shown at right side of long LTR Wi-Fi name.

[4.Actual Result]: 
3. The ellipsis is shown at left side of long LTR Wi-Fi name.

[5.Reproduction build]: 
Device: Flame 2.2 (affected)
Build ID               20150504002502
Gaia Revision          8d14361337e608c8cdf165ea5034db5eda23b618
Gaia Date              2015-05-01 18:23:46
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/cb7cb6597c91
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150504.041436
Firmware Date          Mon May  4 04:14:48 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0 (affected)
Build ID               20150504160201
Gaia Revision          70077825aab2c7a79611befb40a5fe7e610d5443
Gaia Date              2015-05-04 18:09:33
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/102d0e9aa9e1
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150504.193019
Firmware Date          Mon May  4 19:30:30 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 2.2 (affected)
Build ID               20150504002502
Gaia Revision          8d14361337e608c8cdf165ea5034db5eda23b618
Gaia Date              2015-05-01 18:23:46
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/cb7cb6597c91
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150504.041256
Firmware Date          Mon May  4 04:13:14 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5 3.0 (affected)
Build ID               20150504160201
Gaia Revision          70077825aab2c7a79611befb40a5fe7e610d5443
Gaia Date              2015-05-04 18:09:33
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/102d0e9aa9e1
Gecko Version          40.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150504.193136
Firmware Date          Mon May  4 19:31:54 EDT 2015
Bootloader             HHZ12f

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Triage -- P2
Also happens in Settings: see bug 1161455 
(Note: giving this one a higher priority since FTE is 1st impression people get - but not nominating as not critical)

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] sfoster:bidi-ftu-wifi-bug-1161456 > mozilla-b2g:master

Comment 3

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8607774 [details] [review]
[gaia] sfoster:bidi-ftu-wifi-bug-1161456 > mozilla-b2g:master

Can you give this a quick look over Fernando?

Comment 4

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/30133

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

Comment 5

[Sam Foster [:sfoster] (he/him)]

Tree was closed, trying autlander again.

Comment 6

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#ddK6N0U_SrGcAbeRPLaONg

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/d7fe2491618d297969178064707a4ed336d00b7a

Comment 8

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8607774 [details] [review]
[gaia] sfoster:bidi-ftu-wifi-bug-1161456 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): RTL/Bidi in FTE
[User impact] if declined: In RTL languages, long wifi names may get truncated at the wrong end
[Testing completed]: On device, Gaia-Try
[Risk to taking this patch] (and alternatives if risky): Very low risk patch, style-only patch.  
[String changes made]: None

Comment 9

[Josh Cheng [:josh]]

Comment on attachment 8607774 [details] [review]
[gaia] sfoster:bidi-ftu-wifi-bug-1161456 > mozilla-b2g:master

Hi Sue,
Please verify on 2.2 after patch landed there.

Comment 10

[Sam Foster [:sfoster] (he/him)]

v2.2: https://github.com/mozilla-b2g/gaia/commit/246851a4c68102df9828c1a75f9dcabef35ffe9b

Comment 11

[Sue]

Attachment: verify_v3.0_pass.png

This issue has been verified as pass on latest build of Flame 3.0 and Nexus 5 3.0 by STRs in comment 0.
Result: The ellipsis is shown at right side of long LTR Wi-Fi name.
See attachment:verify_v3.0_pass.png
Rate:0/3

Device: Flame 3.0 (pass)
Build ID               20150527160204
Gaia Revision          05380df3158fa39e1dde1687c0bf11a71f8c6868
Gaia Date              2015-05-27 06:27:27
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/2c815cc65cc9
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150527.193645
Firmware Date          Wed May 27 19:36:54 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 3.0 (pass)
Build ID               20150527160204
Gaia Revision          05380df3158fa39e1dde1687c0bf11a71f8c6868
Gaia Date              2015-05-27 06:27:27
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/2c815cc65cc9
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150527.193206
Firmware Date          Wed May 27 19:32:20 EDT 2015
Bootloader             HHZ12f

----------------------------------------------------
I will verify on 2.2 tomorrow.

Comment 12

[Sue]

Attachment: verify_v2.2_pass.png

This issue has been verified as pass on latest build of Flame 2.2 and Nexus 5 2.2.
Result: The ellipsis is shown at right side of long LTR Wi-Fi name.
See attachment:verify_v2.2_pass.png
Rate:0/5

Device: Flame 2.2(Pass)
Build ID               20150528162502
Gaia Revision          a57ec5786c9f941c690266bbb26049dbb8482b05
Gaia Date              2015-05-28 18:08:41
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/7012f97f7814
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150528.201241
Firmware Date          Thu May 28 20:12:53 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus5 2.2 (Pass)
Build ID               20150528162502
Gaia Revision          a57ec5786c9f941c690266bbb26049dbb8482b05
Gaia Date              2015-05-28 18:08:41
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/7012f97f7814
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150528.202725
Firmware Date          Thu May 28 20:27:45 EDT 2015
Bootloader             HHZ11k