1161721 - Return false from document.queryCommandSupported("paste") if calling execCommand("paste") will fail

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

We currently just return true if we can translate the command name to an internal command name, but for paste we need to check to make sure that paste can actually succeed (IOW that the caller has chrome privileges.)

Comment 1

[Hallvord R. M. Steen [:hallvors]]

(Changing summary slightly because I think that's what you meant..)

Comment 2

[(no longer active)]

Yep, thanks!

Comment 4

[Nika Layzell [:nika] (ni? for response)]

oops - queryCommandSupported != queryCommandEnabled

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Return false from document.queryCommandSupported for restricted commands

Comment 6

[Nika Layzell [:nika] (ni? for response)]

Attachment: Return false from document.queryCommandSupported for restricted commands

Acknowledge now-failing browserscope tests

Comment 7

[(no longer active)]

Comment on attachment 8604329 [details] [diff] [review]
Return false from document.queryCommandSupported for restricted commands

Review of attachment 8604329 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but we need to have an explicit test for this too.  Can you please add one?  Ideally, the test would be in two parts, one would be a mochitest-plain, testing non-privileged callers of execCommand, and one would be a mochitest-chrome, testing the privileged callers of execCommand.

Comment 8

[Nika Layzell [:nika] (ni? for response)]

Attachment: Return false from document.queryCommandSupported for restricted commands

Added an explicit test for the feature. Instead of using both mochitest-basic and mochitest-chrome, I decided to use SpecialPowers.wrap(document) to get a privileged call. Hopefully that's an acceptable test.

Comment 9

[Nika Layzell [:nika] (ni? for response)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec92cce1ffcb

Comment 10

[Nika Layzell [:nika] (ni? for response)]

(In reply to Michael Layzell [:mystor] from comment #9)
> try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec92cce1ffcb

Ignore that - wrong bug

Comment 11

[Nika Layzell [:nika] (ni? for response)]

try (includes patches for other bugs): https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3ba5f9e6cc5

Comment 12

[Carsten Book [:Tomcat]]

this failed to apply:

renamed 1161721 -> 0001-Bug-1161721-Return-false-from-document.queryCommandS.patch
applying 0001-Bug-1161721-Return-false-from-document.queryCommandS.patch
patching file dom/tests/mochitest/general/mochitest.ini
Hunk #1 FAILED at 100
1 out of 1 hunks FAILED -- saving rejects to file dom/tests/mochitest/general/mochitest.ini.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh 0001-Bug-1161721-Return-false-from-document.queryCommandS.patch

can you take a look, thanks!

Comment 13

[Nika Layzell [:nika] (ni? for response)]

Attachment: 0001-Bug-1161721-Return-false-from-document.queryCommandS.patch

Sorry - I've rebased the patch onto mozilla-central.

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6635e368ea9e

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6635e368ea9e

Comment 16

[Jean-Yves Perrier [:teoli]]

Updated:
https://developer.mozilla.org/en-US/docs/Web/API/Document/queryCommandSupported
and
https://developer.mozilla.org/en-US/Firefox/Releases/41