1162952 - Fix document.queryCommandEnabled('cut'/'copy') to return true always

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

We should probably return false for now for paste as opposed to throwing when IsEditingOnAfterFlush() returns false.

Comment 1

[Hallvord R. M. Steen [:hallvors]]

While you're looking at and thinking of this, comments on the (feas|desir)ability of https://github.com/w3c/clipboard-apis/issues/4 would be very welcome ;)

Comment 2

[(no longer active)]

(In reply to Hallvord R. M. Steen [:hallvors] from comment #1)
> While you're looking at and thinking of this, comments on the
> (feas|desir)ability of https://github.com/w3c/clipboard-apis/issues/4 would
> be very welcome ;)

See bug 596764.  :-)

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Always return true form document.queryCommandEnabled('cut'/'copy')

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Always return true from document.queryCommandEnabled('cut'/'copy')

Acknowledge now-failing browserscope tests

Comment 6

[(no longer active)]

Comment on attachment 8604327 [details] [diff] [review]
Always return true from document.queryCommandEnabled('cut'/'copy')

Review of attachment 8604327 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/tests/test_bug408231.html
@@ +25,2 @@
>        ["createlink", "true"],
> +      ["cut", "true"],

Can you please uncomment and fix the test for paste further down this array?

Comment 7

[Nika Layzell [:nika] (ni? for response)]

Attachment: Always return true from document.queryCommandEnabled('cut'/'copy')

Un-commented and fixed queryCommandEnabled() test for 'paste'.

The other tests for paste aren't fixed by this patch (they throw).

Comment 8

[Hallvord R. M. Steen [:hallvors]]

One moment.. did we consider returning "true" only in a thread that's user-triggered (i.e. allowed to open a popup) and "false" otherwise?

Comment 9

[(no longer active)]

(In reply to Hallvord R. M. Steen [:hallvors] from comment #8)
> One moment.. did we consider returning "true" only in a thread that's
> user-triggered (i.e. allowed to open a popup) and "false" otherwise?

Oh, thanks for noticing this.  Yes, we should definitely return false when we are not handling the user input.  Michael, do you mind making that change, please?

Comment 10

[(no longer active)]

Comment on attachment 8605330 [details] [diff] [review]
Always return true from document.queryCommandEnabled('cut'/'copy')

r- as per comment 9.

Comment 11

[Hallvord R. M. Steen [:hallvors]]

http://jsfiddle.net/213ov2ah/ tests queryCommandEnabled() for copy and cut - non-user-initiated and user-initiated.

Comment 12

[Nika Layzell [:nika] (ni? for response)]

Attachment: Return true from document.queryCommandEnabled('cut'/'copy') when in privileged or user-initiated code

New patch which now only returns true when in privileged or user-initiated code.

New try in progress: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b6e1e3067e6

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0431f570160d

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0431f570160d

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0431f570160d

Comment 16

[Jean-Yves Perrier [:teoli]]

Updated:
https://developer.mozilla.org/en-US/docs/Web/API/Document/queryCommandSupported
and
https://developer.mozilla.org/en-US/Firefox/Releases/41#Interfaces.2FAPIs.2FDOM