1161785 - [Settings][WiFi] Networks list items do not highlight when selected.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-wifi-highlight.txt

Description:
When tapping a WiFi network list item under Available Networks, the items do not highlight.

Repro Steps:
1) Update a Flame to 20150505010204
2) Open the Settings app and navigate to WiFi.
3) Enable WiFi and tap an available network.

Actual:
Tapping the network does not highlight the list item when it is selected.

Expected:
The network list item is highlighted when selected

Environmental Variables:
Device: Flame 3.0 (319MB)(Full Flash)
Build ID: 20150505010204
Gaia: 70077825aab2c7a79611befb40a5fe7e610d5443
Gecko: 102d0e9aa9e1
Gonk: a9f3f8fb8b0844724de32426b7bcc4e6dc4fa2ed
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Repro frequency: 8/8
See attached: Logcat, Video (URL)

Comment 1

[Martin Shuman [:Marty]]

This issue DOES occur on Flame 2.2, ad 2.1 builds.
Tapping the network does not highlight the list item when it is selected.

Environmental Variables:
Device: Flame 2.2
Build ID: 20150505002501
Gaia: 772a9491909abd02dc67278dd453746e2dd358a8
Gecko: 2df83538ae20
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Environmental Variables:
Device: Flame 2.1
Build ID: 20150505001204
Gaia: b4a03b7ee61de5a479b3cf0916f47e91a43b0f50
Gecko: 4493015380ab
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

---------------------------------------------------------------------

This issue does NOT occur on Flame 2.0.
The network list item is highlighted when selected

Environmental Variables:
Device: Flame 2.0
Build ID: 20150505000201
Gaia: 84898cadf28b1a1fcd03b726cff658de470282f0
Gecko: e67ed29e8ad0
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 32.0 (2.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Peter Bylenga [:PBylenga]]

NI component owner for nomination decision and assignment.

Comment 3

[Hermes Cheng (inactive after July 27, 2015)]

It seems only no hightlighted issue only occurs at wifi list.
EJ, could you help here?

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

let me check first.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] EragonJ:bug-1161785 > mozilla-b2g:master

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8605013 [details] [review]
[gaia] EragonJ:bug-1161785 > mozilla-b2g:master

Arthur, can you help me review this patch if you have time ? Thanks !!

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8605013 [details] [review]
[gaia] EragonJ:bug-1161785 > mozilla-b2g:master

I think this is a reasonable move. The precondition is that when we are using an anchor it must bring users to other panels no matter via href or script.

Note that from now on we should ensure anchors are not used for static texts in the review process.

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Sure !

Comment 9

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/ba3aa7f0fff6cf79c201f2e7d6af007c0b512a1f

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8605013 [details] [review]
[gaia] EragonJ:bug-1161785 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): no
[User impact] if declined: Users will feel bad when clicking on wifi list because we don't provide related visual feedback for them.
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: no

Comment 11

[Shally Li（leave from Mozilla）]

This bug has been verified as pass on latest build of Flame v3.0 and Nexus 5 v3.0 by the STR in Comment 0.

Actual results: The network list item is highlighted when a network item is selected
See attachment: verified_v3.0.mp4
Reproduce rate: 0/6

Device: Flame v3.0 build(Pass)
Build ID               20150514131323
Gaia Revision          338f66e6a96491d2f5854b188c6b141ceb690d97
Gaia Date              2015-05-13 14:08:45
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/633684c4ebc4
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150514.165247
Firmware Date          Thu May 14 16:53:00 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v3.0 build (Pass)
Build ID               20150514010203
Gaia Revision          338f66e6a96491d2f5854b188c6b141ceb690d97
Gaia Date              2015-05-13 14:08:45
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1fab94ad196c
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150514.044222
Firmware Date          Thu May 14 04:42:38 EDT 2015
Bootloader             HHZ12f

--------------------------------------------
Leaving "verifyme" for v2.2 uplift & verification.

Comment 12

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.mp4

Comment 13

[Josh Cheng [:josh]]

Comment on attachment 8605013 [details] [review]
[gaia] EragonJ:bug-1161785 > mozilla-b2g:master

Hi Shally,
Please also help to verify when patch landed on 2.2. Thanks

Comment 14

[Shally Li（leave from Mozilla）]

Hi Josh,

    I will verify this bug when it is fixed on v2.2.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/421d0ce8e069ac7b92fd3f90761243ec8bf390c2

Comment 16

[Shally Li（leave from Mozilla）]

Hi Josh,

    Today I find that this bug can be repro both on Flame/Nexus5 v2.2 and v3.0 when you select an AP quickly, but the repro rate is very low (about 4/20), and I think the user impact is also very low. Could you help to check? 

    You can check "verify_v2.2.mp4" (at time: 00:07~00:10) and "logcat_2232.txt".When I select an AP quickly, the AP maybe not be highlighted.

    With above reason, I intend to hide comment 11 & comment 12, because the bug can be repro with a low rate on v3.0&v2.2.


---------------------------------------------------------------------------------
Device: Flame v2.2 build(Fail)
Build ID               20150519162501
Gaia Revision          63e9eeec3032318f8a240f80b6a184fa4b50b6e1
Gaia Date              2015-05-19 17:52:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4e078e1364d3
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150519.200807
Firmware Date          Tue May 19 20:08:18 EDT 2015
Bootloader             L1TC000118D0

Device: Flame v3.0 build(Fail)
Build ID               20150519160202
Gaia Revision          97dc139f1a690224e98533a86526c4165eed1db5
Gaia Date              2015-05-19 04:43:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4fb7ff694bf5
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150519.193113
Firmware Date          Tue May 19 19:31:25 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v2.2 build (Fail)
Build ID               20150519162501
Gaia Revision          63e9eeec3032318f8a240f80b6a184fa4b50b6e1
Gaia Date              2015-05-19 17:52:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4e078e1364d3
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150519.195445
Firmware Date          Tue May 19 19:55:01 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5 v3.0 build (Fail)
Build ID               20150519160202
Gaia Revision          97dc139f1a690224e98533a86526c4165eed1db5
Gaia Date              2015-05-19 04:43:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4fb7ff694bf5
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150519.191919
Firmware Date          Tue May 19 19:19:36 EDT 2015
Bootloader             HHZ12f

Comment 17

[Shally Li（leave from Mozilla）]

Attachment: verify_v2.2.mp4

Comment 18

[Shally Li（leave from Mozilla）]

Attachment: logcat_2232.txt

Comment 19

[Josh Cheng [:josh]]

Hi EJ,
Could you help to check the verification result from Shally per comment 16?
Do you think we need another bug for that low repo rate issue?
Thanks!

Comment 20

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

After discussing this with Arthur, we think this bug may be related to platform. What we did here is use a:active to apply CSS and make background light-blue. We think the main problem here is because user may click on the element too quickly to make platform unable to apply :active status (or platform did apply it but take if off soon after user's finger moving out and this time is too short for us to notice the change)

If possible, can you try to involve related colleagues from Gecko to shed some lights here for us ? Thanks Josh.

Comment 21

[Josh Cheng [:josh]]

Hi Vincent, Hi Aaron,
Could you please help to find someone else from Wifi Gecko to check this bug?
Thanks!

Comment 22

[Vincent Chang[:vchang][changyihsin]]

I don't think it's related to WiFi in gecko. When user taps different SSIDs with security, the WiFi Web APIs are not used at the moment.

Comment 23

[Aaron Wu]

Hi Henry,

Could you help to check if it has some work on Wifi gecko, thanks!

Comment 24

[Henry Chang [:hchang]]

'Gecko'/'Platform' mentioned in comment 20 is definitely not referring to 'Wifi gecko' 
but the 'Rendering'/'Touch Event' in gecko :)

Comment 25

[Max Ivanov[:MaxIvanov]]

This issue DOES NOT reproducible on Flame/Aire 2.5. The available network is selected either with single or long taps.

Device: Flame 2.5
Build ID: 20150902123525
Gaia: 29f363d6236bf7db8141d7a1f1185a1dcd809bf7
Gecko: a6786bf8d71d4cf40c3d40e06d8e3c9866863475
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Device: Aries 2.5
Build ID: 20150902204109
Gaia: 29f363d6236bf7db8141d7a1f1185a1dcd809bf7
Gecko: a6786bf8d71d4cf40c3d40e06d8e3c9866863475
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Comment 26

[Max Ivanov[:MaxIvanov]]

This issue also DOES NOT reproducible on Flame 2.2

Environmental Variables:
Device: Flame 2.2
Build ID: 20150902032503
Gaia: 335cd8e79c20f8d8e93a6efc9b97cc0ec17b5a46
Gecko: c03e2bc6a3a4
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0