1167790 - [Settings][Media Storage] Storage list items highlight when tapped, but are not selectable items.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-storage-highlight.txt

Description:
In Media Storage and Application Storage, the list items for Music, Pictures, Movies, etc. will all highlight blue when tapped, but do not actually yield and functionality.

Repro Steps:
1) Update a Flame to 20150522001933
2) Launch the Settings app
3) Navigate to Media Storage
4) Tap the Music, Pictures, and Movies list items.

Actual:
The Storage list items highlight blue, but do not produce any functionality.

Expected:
Non-functional list items do not highlight when tapped.

Environmental Variables:
Device: Flame 3.0 (319MB)(Full Flash)
Build ID: 20150522001933
Gaia: 1126d8bee559f7cde675df2fcc6c196da9cfeba1
Gecko: 3e737d30f842
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 41.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Repro frequency: 10/10
See attached: logcat, Video (URL)

Comment 1

[Martin Shuman [:Marty]]

This issue DOES occur on Flame 2.2 builds.
The Storage list items highlight blue, but do not produce any functionality.

Environmental Variables:
Device: Flame 2.2 (319MB)(Full Flash)
Build ID: 20150522002508
Gaia: 9acbac7e6d4a2e3913af4aa202ea403501967fcd
Gecko: a1e8f172523d
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

---------------------------------------------------------------

This issue does NOT occur on Flame 2.1 builds.
The Storage list items do not highlight blue.

Environmental Variables:
Device: Flame 2.1 (319MB)(Full Flash)
Build ID: 20150522001205
Gaia: 0d343f49c0e0a3928a4f456faf98e37bb26a6ef6
Gecko: 23203116eac3
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 2

[Peter Bylenga [:PBylenga]]

NI on Component owner for nomination decision and assignment.

Comment 3

[Gerry Chang [:gchang]]

I found this issue won't happen on below build.
Build ID               20150518162501
Gaia Revision          5212c658a651e04d6d84dfc1bce06b499c0d0d96
Gaia Date              2015-05-18 12:10:52
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/9e9e0d0f45f0
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2

regressionwindow on v2.2, thanks.

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working
Device: Flame
BuildID: 20150513015440
Gaia: 46b305b7e28035a2ee3c20d636e5de8dcb0e1a95
Gecko: 09fba97a7e9b
Version: 41.0a1 (3.0 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

First Broken
Device: Flame
BuildID: 20150513022842
Gaia: 549a48cffcd26115df95639721028c35d7116d44
Gecko: 4cd9a6ea2843
Version: 41.0a1 (3.0 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Last Working Gaia First Broken Gecko - issue does NOT repro
Gaia: 46b305b7e28035a2ee3c20d636e5de8dcb0e1a95
Gecko: 4cd9a6ea2843

Last Working Gecko First Broken Gaia - issue DOES repro
Gaia: 549a48cffcd26115df95639721028c35d7116d44
Gecko: 09fba97a7e9b

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/46b305b7e28035a2ee3c20d636e5de8dcb0e1a95...549a48cffcd26115df95639721028c35d7116d44

Caused by the patch for Bug 1161785.

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

EJ, can you take a look at this please? This looks to have been caused by the work done on bug 1161785.

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Yes, this can be a follow-up bug for bug 1161785, we are planning to fix all existed panels with right HTML format to fix this, I'll take this bug first, thanks.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] EragonJ:bug-1167790 > mozilla-b2g:master

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: demo1.png

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: demo2.png

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Helen, can you help me check my demo images about my patch ? I think the ultimate solution for long string is to make them multiple lines. If these demo images make sense to you, i'll start the review process for this patch !

THanks :)

Comment 11

[Helen Huang [:HHuang]]

I'm fine with showing multiple lines here. They look good.

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks Helen !

Comment 13

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8612144 [details] [review]
[gaia] EragonJ:bug-1167790 > mozilla-b2g:master

Arthur, can you help me review this patch ? Thanks :)

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8612144 [details] [review]
[gaia] EragonJ:bug-1167790 > mozilla-b2g:master

The patch looks good to me except for the part regarding the battery panel. The text for displaying the battery level is not aligned when the phone is fully charged. Please check with Helen if any adjustment is required, thanks!

Comment 15

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: ar.png

Comment 16

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: en.png

Comment 17

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8615769 [details]
en.png

Hi Helen, With this patch, in battery panel, because the "current level" is too long and its layout will be expanded a little bit, can you check en.png & ar.png to see whether this edge case is okay for you ?

Thanks !

Comment 18

[Helen Huang [:HHuang]]

Comment on attachment 8615769 [details]
en.png

I think there is enough space for showing the whole content 'Current Level 100% (charged)’, just to make sure the alignment of this row is same as the others. However, if some language is too long to show completely, I will recommend only show the status in multiple lines but keep label in one line.

Comment 19

[Helen Huang [:HHuang]]

Attachment: Reference.png

Attached mockup for the reference, please let me know if any question.

Comment 20

[BMO Automation]

Firefox OS is not being worked on